[Bug]: Bytebuddy version update causes Invisible parameter type error

[kileys]

What happened?

org.apache.beam.vendor.guava.v26_0_jre.com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalStateException: Invisible parameter type of SerializationTest$1 arg0 for public SerializationTest$1$DoFnInvoker(SerializationTest$1)

https://github.com/Talend/beam-samples/runs/7856722514?check_suite_focus=true

Issue Priority

Priority: 1

Issue Component

Component: dependencies

[kileys]

Unvendored and updated bytebuddy version in PR #17317

[kileys]

@cushon
cc: @lukecwik

[lukecwik]

Out of curiosity does the test pass if we are using bytebuddy 1.11.0 implying a backwards incompatible change with bytebuddy and not due to the unshading of bytebuddy?

[cushon]

I'm seeing it pass with bytebuddy 1.12.3 and earlier, and fail with bytebuddy 1.12.4 and later, regardless of unshading: raphw/byte-buddy#1301

So this is concerning, but it seems like it would have been an issue regardless of unshading when the dependency was upgraded.

[lukecwik]

Thanks, linking the release thread where this was initially communicated for context around the issue: https://lists.apache.org/thread/zxtj1pr81l5nqqxsc4mjwnssflg8jkth

[aromanenko-dev]

I may confirm that I have the same results with different bytebuddy version on my side as @cushon provided above.

Does anyone have an idea why it doesn't fail with Beam CI jobs/tests?

[cushon]

Does anyone have an idea why it doesn't fail with Beam CI jobs/tests?

The bytebuddy regression involves handling of classes in the default package, and the failure from Talend/beam-samples involves a class in the default package: https://github.com/Talend/beam-samples/blob/74b5dfae2b2d1ac4e1272467e7d4584f852b0888/serializableTests/src/test/java/SerializationTest.java#L22. Is it possible the Beam CI isn't exercising transformation of classes in the default package?

[aromanenko-dev]

Right, I don't think we have Java files with default package:

$ pwd
/Users/alexeyromanenko/dev/github/beam
$ grep -inrL "package" --include \*.java 
./sdks/java/testing/jpms-tests/src/main/java/module-info.java

(this found one should be fixed)

[kileys]

Removing the milestone since it's rolled back for the release

[kennknowles]

@aromanenko-dev @cushon is this now resolved? We first reverted for the release, then downgraded the unvendored bytebuddy on the master branch. Do we have confirmation that it is fixed?

[cushon]

It's fixed now: #22814 upgraded to the latest bytebuddy version, which includes a fix, and added a local regression test.