Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask Runner Options test failure. #23838

Open
alxmrs opened this issue Oct 25, 2022 · 3 comments
Open

Dask Runner Options test failure. #23838

alxmrs opened this issue Oct 25, 2022 · 3 comments

Comments

@alxmrs
Copy link
Contributor

alxmrs commented Oct 25, 2022

    Thanks. Python Precommit showing following test failure: https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/6286/
apache_beam.runners.dask.dask_runner_test.DaskOptionsTest.test_parser_destinations__agree_with_dask_client

AssertionError: 'vpt_vp_arg3' not found in ['address', 'loop', 'timeout', 'set_as_default', 'scheduler_file', 'security', 'asynchronous', 'name', 'heartbeat_interval', 'serializers', 'deserializers', 'extensions', 'direct_to_workers', 'connection_limit', 'kwargs']

apache_beam.runners.dask.dask_runner_test.DaskRunnerRunPipelineTest.test_create

TypeError: __init__() got an unexpected keyword argument 'vpt_vp_arg3'

Originally posted by @Abacn in #22421 (comment)

@alxmrs
Copy link
Contributor Author

alxmrs commented Oct 25, 2022

@Abacn: I have a question for you about this test – shouldn't the unexpected argument be dropped due to drop_defaults=True and retain_unknown_options=False?

for opt_name in dask_options.get_all_options(drop_default=True).keys():

@Abacn
Copy link
Contributor

Abacn commented Oct 26, 2022

The unexpected vpt_vp_arg3 is from here:

def test_static_value_provider_positional_argument(self):

Looks like the test is contaminating some pipeline option namespace.

@pabloem
Copy link
Member

pabloem commented Oct 26, 2022

Thanks for catching it. I am deactivating coverage tests in #23841, which seems like it can work around this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants