Deactivate Dask Runner code coverage tests as workaround #23841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #23838 |
Codecov Report
@@ Coverage Diff @@
## master #23841 +/- ##
==========================================
- Coverage 73.84% 73.70% -0.15%
==========================================
Files 706 706
Lines 95473 95473
==========================================
- Hits 70505 70367 -138
- Misses 23656 23794 +138
Partials 1312 1312
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
we can roll forward the coverage test for dask, but it had become flaky so we need to fix it first if that's okay : ) |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Good to me for now. Keep the issue open until forward fix is in and re-enable the coverage. |
alxmrs
approved these changes
Oct 26, 2022
|
Thanks for pointing this out @Abacn -- I was expecting a different interface. |
ryanthompson591
pushed a commit
to ryanthompson591/beam
that referenced
this pull request
Oct 28, 2022
ruslan-ikhsan
pushed a commit
to akvelon/beam
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.