Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tour of Beam] [Task] Fix broken Timer in ToB Run/Cancel button or hide it completely #24617

Closed
olehborysevych opened this issue Dec 9, 2022 · 4 comments · Fixed by #24871
Closed

[Tour of Beam] [Task] Fix broken Timer in ToB Run/Cancel button or hide it completely #24617

olehborysevych opened this issue Dec 9, 2022 · 4 comments · Fixed by #24871
Assignees
@olehborysevych @nausharipov
Labels
P3 playground tour-of-beam
Milestone
2.46.0 Release

Comments

@olehborysevych
Copy link
Collaborator

What needs to happen?

Timer in Tour of Beam Run/Cancel button runs forever. Need to fix it or not show it if it can't be fixed.

Issue Priority
Priority: 3

Issue Component

Component: tour-of-beam
@olehborysevych olehborysevych self-assigned this Dec 9, 2022
@alexeyinkin
Copy link
Contributor

.take-issue

@alexeyinkin
Copy link
Contributor

Plan:

  1. In PlaygroundController, remove executionTime stream.
  2. Move PlaygroundController.runCode method to SnippetEditingController.
  3. Add SnippetEditingController.executionStartDate, set and unset it properly when running, finishing, and cancelling.
  4. Add the calculation of elapsed time to the button itself.

@alexeyinkin alexeyinkin removed their assignment Dec 9, 2022
@nausharipov
Copy link
Contributor

.take-issue

@nausharipov
Copy link
Contributor

@olehborysevych @alexeyinkin is the timer needed?

nausharipov pushed a commit to akvelon/beam that referenced this issue Dec 16, 2022
timer fix rough draft (apache#24617)
4bd3c1a
@nausharipov nausharipov mentioned this issue Dec 16, 2022
Closed
3 tasks
nausharipov pushed a commit to akvelon/beam that referenced this issue Dec 20, 2022
comments (apache#24617)
04266ac
nausharipov pushed a commit to akvelon/beam that referenced this issue Dec 21, 2022
comments (1) (apache#24617)
6fab2b1
nausharipov pushed a commit to akvelon/beam that referenced this issue Dec 29, 2022
cancel run on reset (apache#24617)
73b7687
nausharipov pushed a commit to akvelon/beam that referenced this issue Dec 29, 2022
regenerated mocks (apache#24617)
a92d86e
nausharipov pushed a commit to akvelon/beam that referenced this issue Dec 29, 2022
runStopDate (apache#24617)
86048df
nausharipov pushed a commit to akvelon/beam that referenced this issue Dec 30, 2022
OutputFilterTypeController (apache#24617)
8e42864
nausharipov added a commit to akvelon/beam that referenced this issue Dec 30, 2022
@nausharipov @alexeyinkin
resetErrorMessageText (apache#24617)
db37f84 
Co-authored-by: alexeyinkin <leha@inkin.ru>
nausharipov added a commit to akvelon/beam that referenced this issue Dec 30, 2022
@nausharipov @alexeyinkin
resetErrorMessageText (apache#24617)
e84d96b 
Co-authored-by: alexeyinkin <leha@inkin.ru>
nausharipov pushed a commit to akvelon/beam that referenced this issue Dec 30, 2022
comments (apache#24617)
d79b2f5
@nausharipov nausharipov mentioned this issue Jan 4, 2023
Merged
3 tasks
nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 4, 2023
missing license (apache#24617)
ac2c66f
nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 9, 2023
fixes after merge with master (apache#24617)
f46a093
nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 16, 2023
merge fixes (apache#24617)
56ea583
nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 16, 2023
regenerated yaml files (apache#24617)
93798ea
nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 19, 2023
snippetEditingControllerGetter refinement (apache#24617)
d261b2a
damccorm pushed a commit that referenced this issue Jan 19, 2023
@nausharipov @alexeyinkin
[Playground][Frontend] Run timer fix; CodeRunner and OutputType extra…
1c4e424 
…ction. (#24871)

* timer fix rough draft (#24617)

* comments (#24617)

* comments (1) (#24617)

* cancel run on reset (#24617)

* regenerated mocks (#24617)

* runStopDate (#24617)

* OutputFilterTypeController (#24617)

* resetErrorMessageText (#24617)

Co-authored-by: alexeyinkin <leha@inkin.ru>

* resetErrorMessageText (#24617)

Co-authored-by: alexeyinkin <leha@inkin.ru>

* comments (#24617)

* missing license (#24617)

* a commit for re-running rat check on github

* deleted comment "a commit for re-running rat check on github"

* fixes after merge with master (#24617)

* merge fixes (#24617)

* regenerated yaml files (#24617)

* snippetEditingControllerGetter refinement (#24617)

Co-authored-by: darkhan.nausharipov <darkhan.nausharipov@kzn.akvelon.com>
Co-authored-by: alexeyinkin <leha@inkin.ru>
@github-actions github-actions bot added this to the 2.46.0 Release milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olehborysevych olehborysevych

@nausharipov nausharipov

Labels
P3 playground tour-of-beam
Projects
Tour of Beam
Status: Done
Milestone
2.46.0 Release
3 participants
@olehborysevych @nausharipov @alexeyinkin