Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Python test process #10038

Closed
wants to merge 6 commits into from
Closed

Simplify Python test process #10038

wants to merge 6 commits into from

Commits on Jan 17, 2020

  1. Simplify test process 

    - Use pyproject.toml and pep517 to install requirements for building beam
- Use tox to build sdist of beam instead of gradle sdist
- Don't call python setup.py nosetests because it rebuilds beam
- Do not run tests on code in the source directory
- Run lint jobs against the source
    @chadrik
    chadrik committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    a46e37d View commit details
    Browse the repository at this point in the history

  2. [BEAM-2366] Move generate_proto_files into setup.py

    @chadrik
    chadrik committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    b5090ff View commit details
    Browse the repository at this point in the history

  3. Stop using gradle to build sdist 

    Tox knows how to do this too, and now that we're using pyproject.toml (pep517 & pep518) we can describe how to do this in a portable way.
    @chadrik
    chadrik committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    eee9e4d View commit details
    Browse the repository at this point in the history

  4. Run flink PVR tests inside tox 

    WIP:  trying to debug why these are failing
    @chadrik
    chadrik committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    80f7631 View commit details
    Browse the repository at this point in the history

  5. Ensure that the code is cythonized when we expect it to be 

    Also, fix a bug where cython coder tests were not actually being run
fix


fix


Fixes
    @chadrik
    chadrik committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    80aaa37 View commit details
    Browse the repository at this point in the history

  6. Fix for the google namespace package on python2 

    we have to set the pep517 isolated build directory as the site dir for the google .pth file to work and find the nested protobuf package
    @chadrik
    chadrik committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    ed06bf1 View commit details
    Browse the repository at this point in the history