[BEAM-8979] Remove mypy-protobuf dependency #10400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run BigQueryIO Write Performance Test Python Batch |
|
Run Python 3.7 PostCommit |
1 similar comment
|
Run Python 3.7 PostCommit |
|
Run Python2_PVR_Flink PreCommit |
|
R: @chadrik |
|
@chadrik Let me know if you are fine with this temporary workaround. I hope this does not block your effort to introduce python type hints, and if it does, we'll find another solution. |
|
LGTM. This won’t slow me down too much. Getting the remainder of my typing changes merged with probably take another 2 months (being optimistic), so there will be time to sort this out before the tests need to pass successfully. I suspect this problem will be resolved by using tox for IT. Hopefully @udim and I can team up on this. Sorry for the inconvenience! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts mypy-protobuf changes introduced in #9915 to bring some of the tests back to normal.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.