[BEAM-8280] no_annotations decorator #10904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `@decorators.no_annotations` decorator to disable on a specific function. Split out of apache#10717
kennknowles
reviewed
Feb 20, 2020
| @@ -154,5 +156,23 @@ def fn(a, b=None, *args, foo, **kwargs): | |||
| decorators.getcallargs_forhints(fn, 5) | |||
|
|
|||
|
|
|||
| class DecoratorsTest(unittest.TestCase): | |||
| def test_no_annotations(self): | |||
There was a problem hiding this comment.
Better to split into three test methods.
There was a problem hiding this comment.
It is one test. I'll rewrite it to make it clear. First it shows that the pipeline raises a TypeCheckError with annotations and then it shows no exceptions raised without them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
@decorators.no_annotationsdecorator to disable on a specificfunction.
Split out of #10717
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.