Remove "whitelist" and "blacklist" terminology from repository where possible #11977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this Kenn. Another one: |
probot-autolabeler
bot
added
build
dataflow
extensions
hadoop
io
java
kafka
runners
sql
labels
ibzib
approved these changes
Jun 11, 2020
|
Yes, once the upstream changes are in and released we will edit our config files. |
Is it worth filing a JIRA? |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
Filed https://issues.apache.org/jira/browse/BEAM-10272 for CassandraIOTest failure on https://builds.apache.org/job/beam_PreCommit_Java_Commit/11785/ |
|
run java precommit |
|
Didn't see another Jira. Doesn't seem to be failing on mainline. |
…possible For context, see: - https://tools.ietf.org/html/draft-knodel-terminology-01 - https://developers.google.com/style/inclusive-documentation#features-and-users Blocked by configuration of other projects and vendored code: - tox-dev/tox#1491 - jenkinsci/ghprb-plugin#784 - Generated storage_v1_messages.py (undocumented how we generated this!?) - Many golang vendored modules
|
Finally green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, see:
Blocked by configuration of other projects and vendored code:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.