Skip to content

Conversation

@tiny-dancer
Copy link

Reimplementation of #9232


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@tiny-dancer tiny-dancer changed the title [WIP][BEAM-7819] Python - Include PubSub message_id and publish_time in PubsubMessage [WIP][BEAM-7819] Python - Include message_id and publish_time in PubsubMessage Jul 16, 2020
@stale
Copy link

stale bot commented Sep 19, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Sep 19, 2020
@udim
Copy link
Member

udim commented Sep 24, 2020

Hi, is this still being worked on? I'm asking because I might pick this up. If you want to work on this please let me know and I'd be happy to answer any questions.

@stale stale bot removed the stale label Sep 24, 2020
@tiny-dancer
Copy link
Author

@udim no longer being worked on, last left off where it was working locally but not in dataflow. Feel free to proceed, thank you!

@aaltay
Copy link
Member

aaltay commented Oct 2, 2020

Closing the PR based on the latest comment. @tiny-dancer thank you for working on this up to this point.

@aaltay aaltay closed this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants