Skip to content

Conversation

@y1chi
Copy link
Contributor

@y1chi y1chi commented Jul 9, 2021

…pendency.

google-cloud-profiler doesn't distribute wheel file and this makes building custom container for some user more difficult since they'll need additional compiler toolchain to install the dependency during the docker build process. Remove the dependency for now until google-cloud-profiler starts to distribute the wheels.

User should still able to provide the dependency through requirements.txt if they indeed need to use the google cloud profiling feature on GCP.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@y1chi
Copy link
Contributor Author

y1chi commented Jul 9, 2021

Run PythonLint PreCommit

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #15150 (4ad87f1) into master (000ac07) will increase coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15150      +/-   ##
==========================================
+ Coverage   82.55%   83.81%   +1.25%     
==========================================
  Files         455      441      -14     
  Lines       55143    59555    +4412     
==========================================
+ Hits        45526    49914    +4388     
- Misses       9617     9641      +24     
Impacted Files Coverage Δ
...python/apache_beam/examples/wordcount_dataframe.py 0.00% <0.00%> (-92.60%) ⬇️
...s/python/apache_beam/examples/snippets/snippets.py 76.70% <0.00%> (-12.83%) ⬇️
sdks/python/apache_beam/io/kafka.py 80.00% <0.00%> (-5.72%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 87.80% <0.00%> (-5.06%) ⬇️
...n/apache_beam/runners/direct/test_direct_runner.py 37.50% <0.00%> (-4.81%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 74.72% <0.00%> (-4.81%) ⬇️
test_config.py 66.66% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/runners/test/__init__.py 66.66% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/io/gcp/__init__.py 80.00% <0.00%> (-4.62%) ⬇️
...thon/apache_beam/runners/worker/channel_factory.py 75.00% <0.00%> (-3.95%) ⬇️
... and 459 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41bdd40...4ad87f1. Read the comment docs.

@y1chi
Copy link
Contributor Author

y1chi commented Jul 9, 2021

R: @aaltay

@aaltay
Copy link
Member

aaltay commented Jul 9, 2021

LGTM.

But, why do we have this in the first place? @ajamato - do you know if this is used?

@y1chi
Copy link
Contributor Author

y1chi commented Jul 9, 2021

LGTM.

But, why do we have this in the first place? @ajamato - do you know if this is used?

I added it in #14877

@y1chi y1chi merged commit 943af02 into apache:master Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants