Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gap-filling transform for timeseries #15786

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Add gap-filling transform for timeseries #15786

merged 2 commits into from
Jul 13, 2022

Conversation

reuvenlax
Copy link
Contributor

No description provided.

@kennknowles kennknowles marked this pull request as draft November 8, 2021 19:37
@codecov
Copy link

codecov bot commented Dec 15, 2021 •
edited
Loading

Codecov Report

Merging #15786 (3b22bd3) into master (029a2e3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15786      +/-   ##
==========================================
- Coverage   74.25%   74.24%   -0.01%     
==========================================
  Files         702      702              
  Lines       92961    92999      +38     
==========================================
+ Hits        69028    69047      +19     
- Misses      22666    22685      +19     
  Partials     1267     1267
Flag Coverage Δ
python 83.62% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/transforms/periodicsequence.py 98.38% <0.00%> (-1.62%) ⬇️
sdks/python/apache_beam/internal/dill_pickler.py 85.61% <0.00%> (-1.44%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
...ython/apache_beam/io/gcp/bigquery_read_internal.py 53.36% <0.00%> (-1.05%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...eam/runners/interactive/interactive_environment.py 91.71% <0.00%> (-0.31%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (-0.13%) ⬇️
sdks/python/apache_beam/io/filebasedsink.py 95.90% <0.00%> (-0.08%) ⬇️
sdks/python/apache_beam/io/textio.py 97.05% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029a2e3...3b22bd3. Read the comment docs.

@reuvenlax reuvenlax changed the title perfect rectangles Add gapf-filling transform for timeseries Dec 16, 2021
rezarokni
rezarokni reviewed Dec 16, 2021
View reviewed changes
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Show resolved Hide resolved
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Show resolved Hide resolved
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Outdated Show resolved Hide resolved
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Show resolved Hide resolved
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Outdated Show resolved Hide resolved
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Show resolved Hide resolved
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Outdated Show resolved Hide resolved
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Show resolved Hide resolved
.../extensions/timeseries/src/main/java/org/apache/beam/sdk/extensions/timeseries/FillGaps.java Show resolved Hide resolved
...ensions/timeseries/src/test/java/org/apache/beam/sdk/extensions/timeseries/FillGapsTest.java Outdated Show resolved Hide resolved
@reuvenlax reuvenlax changed the title Add gapf-filling transform for timeseries Add gap-filling transform for timeseries Dec 17, 2021
@reuvenlax
Copy link
Contributor Author

@rezarokni moved this into the beam.extensions package (similar to SQL and other things)

@reuvenlax
Copy link
Contributor Author

Run Java PreCommit

2 similar comments
@reuvenlax
Copy link
Contributor Author

Run Java PreCommit

@reuvenlax
Copy link
Contributor Author

Run Java PreCommit

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 9, 2022
@github-actions github-actions bot removed the website label Apr 9, 2022
@reuvenlax reuvenlax removed the stale label Apr 9, 2022
@reuvenlax
Copy link
Contributor Author

@rezarokni I think this is ready again.

@reuvenlax
Copy link
Contributor Author

Run Java PreCommit

1 similar comment
@reuvenlax
Copy link
Contributor Author

Run Java PreCommit

@rezarokni rezarokni self-requested a review July 12, 2022 22:08
@reuvenlax reuvenlax marked this pull request as ready for review July 13, 2022 17:11
rezarokni
rezarokni approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@rezarokni rezarokni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reuvenlax
Copy link
Contributor Author

Run Java PreCommit

@reuvenlax
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

@reuvenlax reuvenlax merged commit b78a080 into apache:master Jul 13, 2022
@TheNeuralBit
Copy link
Member

Hey @reuvenlax it looks like this broke Java PostCommit: https://ci-beam.apache.org/job/beam_PostCommit_Java/9199/

Can you take a look?

@reuvenlax
Copy link
Contributor Author

reuvenlax commented Jul 20, 2022 via email

@TheNeuralBit
Copy link
Member

It looks like that task was explicitly referenced in the change to build.gradle.kts

@reuvenlax
Copy link
Contributor Author

reuvenlax commented Jul 20, 2022 via email

@TheNeuralBit TheNeuralBit mentioned this pull request Jul 22, 2022
Merged
@TheNeuralBit
Copy link
Member

I sent #22414

lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 26, 2022
@reuvenlax @lostluck
Merge pull request apache#15786: Add gap-filling transform for timese…
82df151 
…ries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezarokni rezarokni rezarokni approved these changes

Assignees
No one assigned
Labels
build extensions java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reuvenlax @TheNeuralBit @rezarokni