[BEAM-14053] [CdapIO] Add wrapper class for CDAP plugin #17150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17150 +/- ##
==========================================
+ Coverage 73.96% 74.12% +0.16%
==========================================
Files 693 680 -13
Lines 91721 89653 -2068
==========================================
- Hits 67838 66454 -1384
+ Misses 22634 22096 -538
+ Partials 1249 1103 -146
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Retest this please |
…M-14048-cdap-config # Conflicts: # sdks/java/io/cdap/build.gradle
# Conflicts: # buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
# Conflicts: # buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy # sdks/java/io/cdap/build.gradle
# Conflicts: # sdks/java/io/cdap/build.gradle
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
@chamikaramj this PR is ready for review |
| for (Annotation annotation : getPluginClass().getDeclaredAnnotations()) { | ||
| if (annotation.annotationType().equals(io.cdap.cdap.api.annotation.Plugin.class)) { |
There was a problem hiding this comment.
Just a nitpick, but there is a method getDeclaredAnnotationsByType that should work as a shortcut.
There was a problem hiding this comment.
Thank you, that's helpful. Done
|
Run Java PreCommit |
|
Run Java PreCommit |
7 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
@chamikaramj PR is ready to be merged |
Warning: This PR contains changes from PR "[BEAM-14048] [CdapIO] Add ConfigWrapper for building CDAP PluginConfigs" and should be merged after it
Changes:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.