fixes [21715] - fix ring range read for CassandraIO read()

[vmarquez]

fixes #21715 (missing data in CassandraIO)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Mention the appropriate issue in your description (for example: "addresses [BEAM-121] Add DisplayData for IO transforms #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "fixes #" instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[asf-ci]

Can one of the admins verify this patch?

[asf-ci]

Can one of the admins verify this patch?

[pabloem]

Run Java PostCommit

[pabloem]

looks like the test is failing: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/23003/testReport/junit/org.apache.beam.sdk.io.cassandra/CassandraIOTest/testWrapAroundRingRanges/

[vmarquez]

@pabloem I fixed a query. Looks ok now. Could you or maybe @damccorm help out with a review if possible? Thanks.

[pabloem]

Run Java PostCommit

[brucearctor]

Run Java PreCommit

[vmarquez]

@brucearctor thanks, looks like the unrelated, flaky test now passed. What are the next steps to getting this merged?

[brucearctor]

I haven't worked with this component [ cassandraIO ] -- so hoping either for more context, or for someone that's worked closer with it to step in.

Is there an associated issue [jira/github] that this relates to/addresses. That would be a start to provide context on what this is/why - which is also useful more generally for anyone looking through the code/changes/history.

Ex, from the PR template: Mention the appropriate issue in your description (for example: "addresses https://github.com/apache/beam/pull/123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "fixes #" instead.

[vmarquez]

@brucearctor thanks. I had "fixing" instead of "fixes" so I guess it didn't auto pick up the issue it addresses, but at the top you should see the issue it's for: #21715

[brucearctor]

@KriKroff you wrote --> https://github.com/KriKroff/beam-cassandraio-bug

Can you take a look and verify this PR addresses this issue?

In principle LGTM, but hoping for a set of eyes more familiar with the component/issue.

[vmarquez]

Thanks for taking a look, really appreciate it @brucearctor

[pabloem]

so sorry. I can't look at this.

[pabloem]

r: @Abacn

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

[Abacn]

LGTM. The added unit test passed, and verified it fails on current master with java.lang.AssertionError: counting/Flatten.PCollections.out: expected:<100> but was:<99>, which means this change fixed the problem

[vmarquez]

@Abacn Thank you so much for the review! :)