[website] Add TPC-DS benchmark documentation #22047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromanenko-dev
force-pushed
the
tpcds-website
branch
from
213a2fa
to
debc7e8
Compare
|
@TheNeuralBit Could you take a look as well (I asked @echauchot too) as a native English speaker for some grammar errors? |
|
yeah I can take a look, sorry for the delay |
echauchot
requested changes
Jul 5, 2022
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
TheNeuralBit
approved these changes
Jul 8, 2022
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
| --runner=SparkRunner | ||
| --dataSize=1GB | ||
| --sourceType=PARQUET | ||
| --dataDirectory=gs://beam-tpcds/datasets/parquet/partitioned |
There was a problem hiding this comment.
Could/should we resolve this path given dataSize and sourceType? (we could still allow the user to override it)
website/www/site/content/en/documentation/sdks/java/testing/tpcds.md
Outdated
Show resolved
Hide resolved
aromanenko-dev
force-pushed
the
tpcds-website
branch
from
debc7e8
to
11ea95d
Compare
|
@echauchot @TheNeuralBit Thanks for review! I tried to address all your comments, ptal |
aromanenko-dev
force-pushed
the
tpcds-website
branch
2 times, most recently
from
1423ccf
to
c7ac497
Compare
|
Run Website PreCommit |
|
Run Website_Stage_GCS PreCommit |
aromanenko-dev
force-pushed
the
tpcds-website
branch
from
c7ac497
to
9efaadf
Compare
|
I addressed the comments and I'll self-merge this PR since it was already LGTM-ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dedicated page for TPC-DS benchmark, like we have for Nexmark one.
Issue #21674
R: @TheNeuralBit
R: @echauchot
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.