New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup sharding javaPostCommit #22081

Merged

damccorm merged 2 commits into apache:master from Abacn:shardfollowup

Jun 28, 2022

Contributor

Abacn commented Jun 28, 2022

Follow up of #21800

Remove integration test depsOn that already sharded

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.


          Followup sharding javaPostCommit

093a5df

* Remove integration test depsOn that already sharded

asf-ci commented Jun 28, 2022

Can one of the admins verify this patch?

4 similar comments

asf-ci commented Jun 28, 2022

Can one of the admins verify this patch?

asf-ci commented Jun 28, 2022

Can one of the admins verify this patch?

asf-ci commented Jun 28, 2022

Can one of the admins verify this patch?

asf-ci commented Jun 28, 2022

Can one of the admins verify this patch?

Contributor Author

Abacn commented Jun 28, 2022

Run Java PostCommit

Contributor Author

Abacn commented Jun 28, 2022

postcommit due to IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Not sure the cause

Contributor Author

Abacn commented Jun 28, 2022

Run Java PostCommit

Contributor Author

Abacn commented Jun 28, 2022

@fernando-wizeline @benWize Jobs created in #21800 and #21804 have file name prefix and templates from PreCommit. But should these be PostCommit ? Also .test-infra/jenkins/README.md needs update

Contributor

benWize commented Jun 28, 2022

@fernando-wizeline @benWize Jobs created in #21800 and #21804 have file name prefix and templates from PreCommit. But should these be PostCommit ? Also .test-infra/jenkins/README.md needs update

@Abacn here is a discussion about it #21808 (comment)

github-actions bot added the build label

Contributor Author

Abacn commented Jun 28, 2022

Thanks for pinning the context. Then I will update the readme to includes this tests in precommit section.


          update readme

01d9797

Contributor Author

Abacn commented Jun 28, 2022

beam_PreCommit_Java_GCP_IO_Direct links not working yet. Likely need to run seed job. Otherwise ready for review

Contributor Author

Abacn commented Jun 28, 2022

R: @benWize
R: @fernando-wizeline

Contributor

fernando-wizeline commented Jun 28, 2022

LGTM.
Thanks for the help @Abacn!

Contributor

benWize commented Jun 28, 2022

LGTM. Thanks, @Abacn

github-actions bot added the infra label

Contributor Author

Abacn commented Jun 28, 2022

damccorm approved these changes

View reviewed changes

Contributor

damccorm left a comment

LGTM - thanks!

damccorm merged commit 25ca4f0 into apache:master

Abacn deleted the shardfollowup branch

June 28, 2022 19:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels