Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error for external BigQuery tables. #22178

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Jul 7, 2022


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #22178 (ae36588) into master (74a2a1b) will increase coverage by 0.14%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master   #22178      +/-   ##
==========================================
+ Coverage   74.23%   74.38%   +0.14%     
==========================================
  Files         702      702              
  Lines       92873    93620     +747     
==========================================
+ Hits        68945    69637     +692     
- Misses      22661    22716      +55     
  Partials     1267     1267              
Flag Coverage Δ
python 83.72% <37.50%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ython/apache_beam/io/gcp/bigquery_read_internal.py 53.36% <0.00%> (-1.05%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery.py 69.93% <75.00%> (-0.31%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
sdks/python/apache_beam/typehints/schemas.py 94.32% <0.00%> (-0.34%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.42% <0.00%> (-0.25%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 94.76% <0.00%> (-0.21%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 77.34% <0.00%> (-0.05%) ⬇️
sdks/python/apache_beam/io/hadoopfilesystem.py 97.28% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a2a1b...ae36588. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @y1chi for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@robertwb
Copy link
Contributor Author

retest this please

@robertwb
Copy link
Contributor Author

Run Python PreCommit

@pabloem
Copy link
Member

pabloem commented Jul 11, 2022

lgtm thanks Robert

@robertwb robertwb merged commit 983e5c0 into apache:master Jul 11, 2022
konstantinurysov pushed a commit to akvelon/beam that referenced this pull request Jul 14, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants