Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error due to dep confliction of google-cloud-bigquery-storage and google-cloud-core #22205

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jul 8, 2022

Fixes #22204

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label Jul 8, 2022
@Abacn Abacn changed the title Fix build error due to dep confliction of google-cloud-bigquery-storage and grpcio-gcp Fix build error due to dep confliction of google-cloud-bigquery-storage and google-cloud-core Jul 8, 2022
@Abacn
Copy link
Contributor Author

Abacn commented Jul 8, 2022

docker jobs failing due to untitaker/python-atomicwrites#61 which is another surprising mistake upstream

@github-actions github-actions bot added the docker label Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #22205 (315322b) into master (b9093fb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22205   +/-   ##
=======================================
  Coverage   74.22%   74.23%           
=======================================
  Files         702      702           
  Lines       92937    92954   +17     
=======================================
+ Hits        68985    69004   +19     
+ Misses      22685    22683    -2     
  Partials     1267     1267           
Flag Coverage Δ
python 83.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.57% <0.00%> (-0.57%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 94.76% <0.00%> (-0.21%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (-0.13%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 77.34% <0.00%> (-0.05%) ⬇️
sdks/python/apache_beam/typehints/typehints.py 93.42% <0.00%> (+0.05%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
sdks/python/apache_beam/transforms/core.py 92.83% <0.00%> (+0.26%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.39% <0.00%> (+1.32%) ⬆️
...python/apache_beam/runners/worker/worker_status.py 79.71% <0.00%> (+1.44%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9093fb...315322b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Jul 8, 2022

One fn runner failure due to known flake unrelated. Other python tasks and docker tasks passed. Should be ready to merge.

R: @robertwb Thanks for taking a look

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Python builds fail with google-api-core dep version cannot be satisfied
2 participants