Remove deprecated unused option in seed job script #22223
Conversation
|
R: @ahmedabu98 |
|
R: @damccorm Needs Committer to run seed job. Thanks! |
| @@ -63,7 +63,6 @@ def get_committers_github_usernames(ldap_uris, cert_path): | |||
| connection = None | |||
| try: | |||
| ldap.set_option(ldap.OPT_X_TLS_CACERTFILE, cert_path) | |||
| ldap.set_option(ldap.OPT_X_TLS, ldap.OPT_X_TLS_DEMAND) | |||
There was a problem hiding this comment.
What was this trying to do before?
There was a problem hiding this comment.
According to this python-ldap/python-ldap#67 "OPT_X_TLS is deprecated and no longer documented in OpenLDAP: https://www.openldap.org/lists/openldap-software/200409/msg00617.html" (which says "This ldap_set_option(LDAP_OPT_X_TLS) feature is used to explicitly establish an ldaps session. The use of ldaps comes from LDAP version 2 and is deprecated;")
There was a problem hiding this comment.
Ah, I see - so now it should be inferred and we don't need the explicit option (and it throws). Thanks for the context, just wanted to make sure we weren't losing something we'd need to replace
|
Run Spotless PreCommit |
|
(Borrowed this PR to see the change of #22203 after seedjob successfully run. As expected the checkStyle Tab appears: https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Phrase/140/checkstyle/ ) |
There was a problem hiding this comment.
LGTM since the job Pablo kicked off worked - https://ci-beam.apache.org/job/beam_SeedJob/9966/
Fixes #22184
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.