Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.pentaho to calcite relocated packages to fix vendoring validation #22228

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

byronellis
Copy link
Contributor

Adds the org.pentaho packages to the relocated packages list. This fixes vendoring validation errors with calcite-1_28_0-0.2. I do not believe there is an open issue for this right now (at least a search didn't turn one up)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

I removed that line in #17749 because I thought transitive pentaho dependencies were eliminated from beam with that update. In which case this generates an error?

@byronellis
Copy link
Contributor Author

It would appear that those dependencies haven't been removed? From a clean checkout of master this is the error when running a naive build:

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':vendor:calcite-1_28_0:validateVendoring'.
    at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:147)
    at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:282)
    at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:145)
    at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:133)
    at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:77)
    at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
    at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
    at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
    at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
    at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
    at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
    at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
    at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all right, it is net.hydromatic:aggdesigner-algorithm:6.0 but still uses org.pentaho in module name. Shouldn't have removed it

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

R: @chamikaramj Would you mind merging this. Just a line I have mistakenly removed as part of #17749 (/vendor changes does not affect sdk release, thankfully). Unrelated python test failure due to ongoing google-cloud-* dep issues (#22204)

FOr issue link, this could be linked as a follow up of #19554

@byronellis
Copy link
Contributor Author

Ah, okay. (fun fact: Apparently the maintainer of that particular package works at Looker these days)

@chamikaramj
Copy link
Contributor

Ack. Merging.

@chamikaramj chamikaramj merged commit 139ca67 into apache:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants