-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google-cloud-core dependency to <3 #22237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22237 +/- ##
==========================================
- Coverage 74.25% 74.23% -0.02%
==========================================
Files 702 702
Lines 92961 92997 +36
==========================================
+ Hits 69028 69040 +12
- Misses 22666 22690 +24
Partials 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks like pypi correctly picked sub-latest google-cloud-pubsub 2.13.1 with this change. However, if removing the constraint of google-cloud-bigquery-storage pypi becomes crazy again. Would not be surprise if this problem came in again if another google-cloud-* gets updated Update: test log shows there are still hundred lines of |
According to the release note of google-cloud-core 2.0.0, the breaking change is only dropping support for python 2.7. And tests passed. dependency owner for this is empty in OWNERSHIP/PYTHON_DEPENDENCY_OWNERS.yaml. Should be good to go if gcp integration tests passed. |
beam_PostCommit_Python38 |
beam_PostCommit_Python37 |
Run Python Dataflow ValidatesRunner |
Run Python Dataflow V2 ValidatesRunner |
Run Python 3.7 PostCommit |
Run Python 3.8 PostCommit |
Run Python 3.9 PostCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @yeandy for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Python 3.8 PostCommit |
Let's:
we won't submit the second PRs, but just use it as a due diligence to run integration tests in an environment where we forcefully update to the newer version of these dependencies during job submission as well as in worker containers. Once the tests pass, we'll merge this PR and close the other one. Thanks! |
The second one won't pass: there is another hindrance, see #22208 (comment) To fix completely we'll also need to bump google-cloud-recommendation-ai in which I am not sure whether it breaks something. Will need dep owner for that one. |
Ok, let's proceed with incremental changes. I also spoke with google-cloud-core maintainers who agreed that the only major change there was dropping py2 support. |
resolves #22208
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.