Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-cloud-core dependency to <3 #22237

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

johnjcasey
Copy link
Contributor

resolves #22208

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@johnjcasey
Copy link
Contributor Author

@Abacn

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #22237 (c738c46) into master (a8775f0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22237      +/-   ##
==========================================
- Coverage   74.25%   74.23%   -0.02%     
==========================================
  Files         702      702              
  Lines       92961    92997      +36     
==========================================
+ Hits        69028    69040      +12     
- Misses      22666    22690      +24     
  Partials     1267     1267              
Flag Coverage Δ
python 83.61% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/internal/dill_pickler.py 85.61% <0.00%> (-1.44%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
...ython/apache_beam/io/gcp/bigquery_read_internal.py 53.36% <0.00%> (-1.05%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...eam/runners/interactive/interactive_environment.py 91.71% <0.00%> (-0.31%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.94% <0.00%> (-0.16%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8775f0...c738c46. Read the comment docs.

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

Looks like pypi correctly picked sub-latest google-cloud-pubsub 2.13.1 with this change. However, if removing the constraint of google-cloud-bigquery-storage pypi becomes crazy again. Would not be surprise if this problem came in again if another google-cloud-* gets updated

Update: test log shows there are still hundred lines of WARNING: google-api-core 2.8.2 does not provide the extra 'grpcgcp' which indicates pypi is still struggling to resolve deps, though no longer causing timeout.

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

According to the release note of google-cloud-core 2.0.0, the breaking change is only dropping support for python 2.7. And tests passed. dependency owner for this is empty in OWNERSHIP/PYTHON_DEPENDENCY_OWNERS.yaml. Should be good to go if gcp integration tests passed.

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

beam_PostCommit_Python38

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

beam_PostCommit_Python37

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

Run Python Dataflow ValidatesRunner

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

Run Python Dataflow V2 ValidatesRunner

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

Run Python 3.7 PostCommit

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

Run Python 3.8 PostCommit

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

Run Python 3.9 PostCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @yeandy for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@johnjcasey
Copy link
Contributor Author

Run Python 3.8 PostCommit

@tvalentyn tvalentyn self-assigned this Jul 12, 2022
@tvalentyn
Copy link
Contributor

Let's:

  1. also bump the upper bound for:
            'google-cloud-bigquery-storage>=2.6.3,<3',
  1. make a clone of this PR where we additionally set the following lower bounds:
google-cloud-bigquery-storage>=2.14.0
google-cloud-core>=2

we won't submit the second PRs, but just use it as a due diligence to run integration tests in an environment where we forcefully update to the newer version of these dependencies during job submission as well as in worker containers.

Once the tests pass, we'll merge this PR and close the other one.

Thanks!

@Abacn
Copy link
Contributor

Abacn commented Jul 12, 2022

Let's:

  1. also bump the upper bound for:
            'google-cloud-bigquery-storage>=2.6.3,<3',
  1. make a clone of this PR where we additionally set the following lower bounds:
google-cloud-bigquery-storage>=2.14.0
google-cloud-core>=2

we won't submit the second PRs, but just use it as a due diligence to run integration tests in an environment where we forcefully update to the newer version of these dependencies during job submission as well as in worker containers.

Once the tests pass, we'll merge this PR and close the other one.

Thanks!

The second one won't pass: there is another hindrance, see #22208 (comment)

To fix completely we'll also need to bump google-cloud-recommendation-ai in which I am not sure whether it breaks something. Will need dep owner for that one.

@tvalentyn
Copy link
Contributor

Ok, let's proceed with incremental changes. I also spoke with google-cloud-core maintainers who agreed that the only major change there was dropping py2 support.

@tvalentyn tvalentyn merged commit d4d7d93 into apache:master Jul 12, 2022
konstantinurysov pushed a commit to akvelon/beam that referenced this pull request Jul 14, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Allow google-cloud-core 2
3 participants