Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Xlang Go examples to generic registration #22249

Merged
merged 9 commits into from
Jul 13, 2022

Conversation

jrmccluskey
Copy link
Contributor

Shift to using the new generic registration for DoFns, combiners, iterators, and emitters in the cross-language Go example pipelines.

Part of #22243


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it - just one small piece of feedback!

sdks/go/examples/xlang/cogroup_by/cogroup_by.go Outdated Show resolved Hide resolved
@damccorm damccorm merged commit 2c8e7eb into apache:master Jul 13, 2022
konstantinurysov pushed a commit to akvelon/beam that referenced this pull request Jul 14, 2022
* WC generics

* Partition generics

* GroupBy generics

* Flatten generics

* combine_globally generics

* Combine generics

* CoGBK generics

* BigQuery generics

* Remove old versions
lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 26, 2022
* WC generics

* Partition generics

* GroupBy generics

* Flatten generics

* combine_globally generics

* Combine generics

* CoGBK generics

* BigQuery generics

* Remove old versions
@jrmccluskey jrmccluskey deleted the xlangGenerics branch July 11, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants