Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] change getting window width method #22256

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

bullet03
Copy link
Contributor

@bullet03 bullet03 commented Jul 13, 2022

On resolutions between 1025px and 1041px right side menu overlaped left side menu. Reason is in page-nav,js in $(window).width(), which didn't get correct width since it didn't include horizontall scroll width. Used window.innerWidth instead to get correct width.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@bullet03
Copy link
Contributor Author

before:
width_bug

after:
width_fix

@bullet03 bullet03 force-pushed the website-fix-menus-overlap branch 2 times, most recently from 87a3423 to 43606c0 Compare July 18, 2022 12:08
@alevtinaboiko
Copy link

Verified, works as expected. Reviewed and tested by QA

@bullet03 bullet03 marked this pull request as ready for review July 19, 2022 17:45
@bullet03
Copy link
Contributor Author

@pcoet, could you, please, review this PR? It is ready.

@bullet03
Copy link
Contributor Author

@aromanenko-dev, could you, please, help to merge current PR. It was approved.

@aromanenko-dev aromanenko-dev merged commit 1cd5d73 into apache:master Jul 22, 2022
@aromanenko-dev
Copy link
Contributor

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants