Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn pr bot on for remaining common labels #22257

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Jul 13, 2022

This turns on the PR bot for the remaining few labels (Java/Io/Build) that get a lot of PR traffic. I did my best to come up with an initial set of reviewers to be round robined to, but it was mostly based on manual inspection. The bot should eventually update that list anyways.

Closes #21421


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Jul 13, 2022
@damccorm damccorm marked this pull request as ready for review July 13, 2022 16:41
@damccorm
Copy link
Contributor Author

R: @Abacn

return false;
}
const firstPrToProcess = new Date(2022, 5, 16, 14); // June 16 2022, 14:00 UTC (note that Java months are 0 indexed)
const firstPythonPrToProcess = new Date(2022, 5, 16, 14); // June 16 2022, 14:00 UTC (note that JavaScript months are 0 indexed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these date filters (see below)
The Get request in processNewPrs will get at most 30 latest created open prs (according to https://docs.github.com/en/rest/pulls/pulls#list-pull-requests)

Copy link
Contributor Author

@damccorm damccorm Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! We do need it though - if you look at

let openPulls = await githubClient.paginate(
"GET /repos/{owner}/{repo}/pulls",
{
owner: REPO_OWNER,
repo: REPO,
}
);
its called with paginate which automatically pulls all the pages of results (using continuation tokens). So it does get all open pulls. Otherwise I would've just called the octokit method for listing pulls directly instead of using the rest API.

Also, for posterity, this filter is so that the bot doesn't activate on pulls where reviews are already in progress

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. LGTM

@damccorm damccorm merged commit 7dcc6d8 into apache:master Jul 15, 2022
@damccorm damccorm deleted the users/damccorm/prBotOnEverywhere branch July 15, 2022 17:47
lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 26, 2022
* Turn pr bot on for remaining common labels

* Update start time to several hours from now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn pr-bot on for whole repo
2 participants