Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed [Playground] DeployExamples, modified "get difference" step, execution tr… #22300

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

MakarkinSAkvelon
Copy link
Contributor

@MakarkinSAkvelon MakarkinSAkvelon commented Jul 15, 2022

The following flow will be applied:
Once a [Playground] merged to master branch, this pipeline will be triggered. It executes both jobs: collect examples and deploy examples. The change between examples is controlled by "get Difference" step: it's compare previous commit with the current one (git diff --name-only ${{ github.event.before }} ${{ github.event.after }}) (assuming that all PRs are squashed to 1 commit on merge to master). Pipeline trigger was also change: Now it will execute once pull request will me merged


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@MakarkinSAkvelon MakarkinSAkvelon changed the title Fixed PG DeployExamples, modified "get difference" step, execution tr… Fixed [Playground] DeployExamples, modified "get difference" step, execution tr… Jul 15, 2022
@MakarkinSAkvelon MakarkinSAkvelon marked this pull request as ready for review July 15, 2022 16:53
@VladMatyunin
Copy link
Contributor

R: @pabloem

@github-actions github-actions bot added the build label Jul 15, 2022
@VladMatyunin
Copy link
Contributor

There is an assumption: "... all PRs are squashed to 1 commit on merge to master".
I've checked some PRs in the repository, and seems like there are all squashed before merge. Please LMK if you have concerns on that.

@pabloem
Copy link
Member

pabloem commented Jul 15, 2022

lgtm

@pabloem
Copy link
Member

pabloem commented Jul 15, 2022

... wait - we don't always squash commits before merging. Do you htink we could use the branch in the PR and compare against master before the merge?

@pabloem
Copy link
Member

pabloem commented Jul 15, 2022

@VladMatyunin
Copy link
Contributor

... wait - we don't always squash commits before merging. Do you htink we could use the branch in the PR and compare against master before the merge?

The problem with this is that the PR may come from a fork and it won't be assumed as protected branch. Therefore, the secrets won't work there and the pipeline won't be able to authenticate to GCP.
I'll explore the web hook approach, thank you, Pablo!

@pabloem pabloem merged commit 2a42b96 into apache:master Jul 16, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants