Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial read_gbq wrapper #22616
Add initial read_gbq wrapper #22616
Changes from all commits
1f82af4
a1ac3e9
73987e9
fe07f19
9519660
b284638
583d8cd
1c49622
68396e9
88b078a
ffdd87a
87cd8e5
69925a1
dd473b3
8094bbc
9c53709
7e42abf
ea9013c
73bef37
d2c1260
a17f508
5739fd9
d4b0dbd
c324c7f
fbcba75
9f4bbd0
7f3c452
25770a7
81c04e9
5ba1806
f990db8
a9d8657
e1eea91
e106cdc
47560b0
2d8be2c
2c7a6c6
b80e74d
13865e2
3d17f62
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will make the RAT check happy. To confirm you could run
./gradlew rat
locally and inspect the output (build/reports/rat/index.html
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens with read_gbq if GCP dependencies are not installed? Maybe we should not define it in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried without this, and the tests passed locally but failed on Jenkins and thus I wasn't able to easily reproduce the issue. Can discuss this offline if you think it's worth looking further into.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you do an experiment to see what the error looks like if you try to use
read_gbq
without gcp dependencies installed? It should be sufficient to just make a new virtualenv, and install beam withpython -m pip install -e '.[test,dataframe]'
(note there's no gcp extra).I'd like to make sure that the user gets a helpful error directing them to install GCP deps.
Even better would be to add a test that confirms this, it could be skipped unless GCP deps are not installed.