Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Map State integration test #22898

Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 25, 2022

Adds an integration test for map state. Part of #22736


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

Run Go PostCommit

@github-actions github-actions bot added the go label Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #22898 (ae3950d) into master (0c82583) will decrease coverage by 0.02%.
The diff coverage is 18.44%.

❗ Current head ae3950d differs from pull request most recent head f121679. Consider uploading reports for the commit f121679 to get more accurate results

@@            Coverage Diff             @@
##           master   #22898      +/-   ##
==========================================
- Coverage   73.69%   73.67%   -0.03%     
==========================================
  Files         713      713              
  Lines       94822    94676     -146     
==========================================
- Hits        69878    69751     -127     
+ Misses      23645    23635      -10     
+ Partials     1299     1290       -9     
Flag Coverage Δ
go 50.78% <18.44%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/graph/fn.go 84.54% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/exec/data.go 0.00% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/translate.go 12.94% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/graphx/translate.go 38.91% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/harness/statemgr.go 37.75% <0.00%> (ø)
sdks/go/pkg/beam/pardo.go 42.10% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/exec/userstate.go 6.43% <1.30%> (ø)
sdks/go/pkg/beam/core/state/state.go 75.28% <75.82%> (ø)
sdks/go/pkg/beam/core/runtime/exec/fn.go 68.32% <0.00%> (-2.45%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/datasource.go 65.55% <0.00%> (-0.75%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor Author

Run Go PostCommit

@damccorm
Copy link
Contributor Author

Run Go PostCommit

@damccorm damccorm changed the title WIP: MapState integration test Go Map State integration test Aug 26, 2022
@damccorm
Copy link
Contributor Author

R: @riteshghorse

@damccorm damccorm marked this pull request as ready for review August 26, 2022 21:10
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@damccorm damccorm merged commit 9ca1f7a into apache:master Aug 29, 2022
@damccorm damccorm deleted the users/damccorm/mapStateIntegrationTest branch August 29, 2022 15:10
dedocibula pushed a commit to dedocibula/beam that referenced this pull request Sep 15, 2022
* Add map state in the Go Sdk

* Remove unused function for now

* WIP: MapState integration test

* WIP: MapState integration test

* fix bad merge
kkdoon pushed a commit to twitter-forks/beam that referenced this pull request Sep 29, 2022
* Add map state in the Go Sdk

* Remove unused function for now

* WIP: MapState integration test

* WIP: MapState integration test

* fix bad merge
cushon pushed a commit to cushon/beam that referenced this pull request Oct 17, 2022
* Add map state in the Go Sdk

* Remove unused function for now

* WIP: MapState integration test

* WIP: MapState integration test

* fix bad merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants