Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear function for bag state types #22917

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

damccorm
Copy link
Contributor

This allows all the bag type states to clear their state and adds tests/integration tests for them.

Part of #22736


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

Run Go PostCommit

@github-actions github-actions bot added the go label Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #22917 (5afddea) into master (0c82583) will decrease coverage by 0.00%.
The diff coverage is 40.54%.

@@            Coverage Diff             @@
##           master   #22917      +/-   ##
==========================================
- Coverage   73.69%   73.68%   -0.01%     
==========================================
  Files         713      713              
  Lines       94821    94855      +34     
==========================================
+ Hits        69874    69893      +19     
- Misses      23648    23663      +15     
  Partials     1299     1299              
Flag Coverage Δ
go 50.95% <40.54%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/userstate.go 6.07% <0.00%> (-0.36%) ⬇️
sdks/go/pkg/beam/core/state/state.go 76.59% <100.00%> (+1.31%) ⬆️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.22% <0.00%> (+0.15%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.24%) ⬆️
...s/python/apache_beam/examples/wordcount_minimal.py 92.85% <0.00%> (+0.26%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (+0.74%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor Author

Go Run PostCommit

@damccorm
Copy link
Contributor Author

Run Go Postcommit

@damccorm
Copy link
Contributor Author

R: @riteshghorse

@damccorm damccorm marked this pull request as ready for review August 26, 2022 22:11
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdks/go/test/integration/integration.go Show resolved Hide resolved
@damccorm damccorm merged commit 90baef1 into apache:master Aug 29, 2022
@damccorm damccorm deleted the users/damccorm/bagStateClear branch August 29, 2022 15:11
dedocibula pushed a commit to dedocibula/beam that referenced this pull request Sep 15, 2022
* Add clear function for bag state types

* Doc comment

* Register functions
kkdoon pushed a commit to twitter-forks/beam that referenced this pull request Sep 29, 2022
* Add clear function for bag state types

* Doc comment

* Register functions
cushon pushed a commit to cushon/beam that referenced this pull request Oct 17, 2022
* Add clear function for bag state types

* Doc comment

* Register functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants