-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set state in Go #22919
Merged
Merged
Add set state in Go #22919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22919 +/- ##
==========================================
- Coverage 73.69% 73.68% -0.01%
==========================================
Files 713 713
Lines 94821 94930 +109
==========================================
+ Hits 69874 69945 +71
- Misses 23648 23684 +36
- Partials 1299 1301 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
4 tasks
riteshghorse
requested changes
Aug 29, 2022
Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
riteshghorse
approved these changes
Aug 29, 2022
dedocibula
pushed a commit
to dedocibula/beam
that referenced
this pull request
Sep 15, 2022
* Add set state in Go * Update sdks/go/pkg/beam/core/state/state_test.go Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com> * Update sdks/go/pkg/beam/core/state/state_test.go Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com> * Remove unneccessary conversion Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
kkdoon
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Sep 29, 2022
* Add set state in Go * Update sdks/go/pkg/beam/core/state/state_test.go Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com> * Update sdks/go/pkg/beam/core/state/state_test.go Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com> * Remove unneccessary conversion Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
Oct 17, 2022
* Add set state in Go * Update sdks/go/pkg/beam/core/state/state_test.go Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com> * Update sdks/go/pkg/beam/core/state/state_test.go Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com> * Remove unneccessary conversion Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues to grow our state support by adding map state support. Once this is in, I'll add a follow up PR with an integration test. In the meantime, I tested manually by running the hacked wordcount found here - https://github.com/damccorm/beam/pull/96/files#diff-46f0bd8f9f6b541e840079960d684ba78e6513f1293b673d08faaec94d48a234 - and it produced output like:
Note that this doesn't add support for Remove (to remove a single key). This will come in a future pr and has been noted in #22736
Part of #22736
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.