Add ability to remove/clear map and set state #22938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22938 +/- ##
==========================================
+ Coverage 73.69% 73.71% +0.01%
==========================================
Files 713 713
Lines 94988 95169 +181
==========================================
+ Hits 69998 70150 +152
- Misses 23689 23722 +33
+ Partials 1301 1297 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…damccorm/clearMapState
|
Run Go PostCommit |
damccorm
changed the title
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Run Go PostCommit |
riteshghorse
approved these changes
Aug 30, 2022
|
retest this please |
|
GoPortable completed successfully, but seems to be having a hard time updating status here. I'm not going to block on that |
dedocibula
pushed a commit
to dedocibula/beam
that referenced
this pull request
Sep 15, 2022
* WIP: Add ability to remove/clear map and set state * Add set test + fix map test * String fix * Add missing set state test * go fmt
kkdoon
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Sep 29, 2022
* WIP: Add ability to remove/clear map and set state * Add set test + fix map test * String fix * Add missing set state test * go fmt
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
Oct 17, 2022
* WIP: Add ability to remove/clear map and set state * Add set test + fix map test * String fix * Add missing set state test * go fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Remove and Clear operations for maps and sets + an integration test. I also removed some TODOs around caching our encoders/decoders since making them is cheap and caching them doesn't get us much.
Part of #22736
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.