Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Exclude protobuf 3.20.2" #23237

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 14, 2022

@Abacn
Copy link
Contributor Author

Abacn commented Sep 14, 2022

Tests likely will pass.

@Abacn Abacn marked this pull request as ready for review September 14, 2022 20:12
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #23237 (c738b9d) into master (9b83b79) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23237   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files         716      716           
  Lines       95327    95327           
=======================================
+ Hits        70142    70150    +8     
+ Misses      23889    23881    -8     
  Partials     1296     1296           
Flag Coverage Δ
python 83.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...python/apache_beam/runners/worker/worker_status.py 75.33% <0.00%> (-1.34%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.24%) ⬆️
sdks/python/apache_beam/transforms/combiners.py 93.43% <0.00%> (+0.38%) ⬆️
sdks/python/apache_beam/internal/metrics/metric.py 94.00% <0.00%> (+1.00%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.39% <0.00%> (+1.32%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor Author

Abacn commented Sep 14, 2022

R: @tvalentyn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Sep 15, 2022

"apache_beam.runners.portability.fn_api_runner.fn_runner_test.FnApiRunnerTestWithGrpcAndMultiWorkers.test_batch_pardo_trigger_flush" failed due to known flake #21104

@tvalentyn
Copy link
Contributor

LGTM

@tvalentyn tvalentyn merged commit c871d15 into apache:master Sep 15, 2022
@Abacn Abacn deleted the revert-23226-pypifail branch September 15, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants