Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate Go Protos #23408

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Regenerate Go Protos #23408

merged 2 commits into from
Sep 28, 2022

Conversation

lostluck
Copy link
Contributor

Protos were updated to support additional cross language transforms.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the go label Sep 28, 2022
@lostluck
Copy link
Contributor Author

R: @riteshghorse

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #23408 (b146f61) into master (a393efa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23408   +/-   ##
=======================================
  Coverage   73.41%   73.41%           
=======================================
  Files         718      718           
  Lines       95652    95652           
=======================================
  Hits        70222    70222           
  Misses      24119    24119           
  Partials     1311     1311           
Flag Coverage Δ
go 50.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lostluck
Copy link
Contributor Author

OK @riteshghorse This is ready for a look.

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lostluck lostluck merged commit e53466f into master Sep 28, 2022
@lostluck lostluck deleted the regenprotoExp branch December 1, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants