Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GCP OAuth scopes configurable via pipeline options. #23644

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Make GCP OAuth scopes configurable via pipeline options. #23644

merged 3 commits into from
Oct 15, 2022

Commits on Oct 14, 2022

  1. Make GCP OAuth scopes configurable via pipeline options. 

    This allows users to limit scopes dependent on their pipeline.

fixes apache#23290
    @lukecwik
    lukecwik committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ac50133 View commit details
    Browse the repository at this point in the history

  2. Fix usages of get credentials where no pipeline options was being use… 

    …d to pass in a default instance
    @lukecwik
    lukecwik committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    b206342 View commit details
    Browse the repository at this point in the history

  3. Address review comments 

    Drop the non pipelineoptions routes in _add_impersonation_...
    @lukecwik
    lukecwik committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    1d6a0e0 View commit details
    Browse the repository at this point in the history