Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google cloud vision >= 2.0.0 #23755

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Oct 20, 2022

Fixes: #23261

Update google-cloud-vision dependency to >= 2.0.0

2.0.0 has some breaking changes and needed some changes to PTransforms that depend on google-cloud-vision.

For more information: https://googleapis.dev/python/vision/latest/UPGRADING.html


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@AnandInguva
Copy link
Contributor Author

Run Python 3.8 PostCommit

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #23755 (5e4c544) into master (3ab9507) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master   #23755      +/-   ##
==========================================
- Coverage   73.17%   73.17%   -0.01%     
==========================================
  Files         720      720              
  Lines       96044    96044              
==========================================
- Hits        70278    70276       -2     
- Misses      24454    24456       +2     
  Partials     1312     1312              
Flag Coverage Δ
python 82.94% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/ml/gcp/visionml.py 92.59% <90.00%> (ø)
sdks/python/apache_beam/ml/gcp/visionml_test_it.py 66.66% <100.00%> (ø)
sdks/python/apache_beam/internal/gcp/auth.py 78.57% <0.00%> (-4.29%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 93.28% <0.00%> (-0.75%) ⬇️
sdks/python/apache_beam/coders/coders.py 87.48% <0.00%> (+0.12%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva
Copy link
Contributor Author

AnandInguva commented Oct 20, 2022

R: @tvalentyn @ryanthompson591

@AnandInguva
Copy link
Contributor Author

Got a green on the PostCommit and also the unittests testing the google-cloud-vision passes. Precommit failure is unrelated.

https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/656/testReport/apache_beam.ml.gcp.visionml_test_it/

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

Precommit failure is unrelated.

It's #21104

@tvalentyn tvalentyn merged commit a138a4f into apache:master Oct 20, 2022
@tvalentyn
Copy link
Contributor

LGTM. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: google-cloud-vision 3.x doesn't work in Beam
2 participants