-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Spark 3 job-server jar path for Python test suites #23936
Conversation
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Run Python Examples_Spark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Run Python PreCommit |
Run Python Examples_Spark |
The failing Spark example tests are due to another issue #23907 |
Codecov Report
@@ Coverage Diff @@
## master #23936 +/- ##
==========================================
- Coverage 73.52% 73.51% -0.01%
==========================================
Files 707 707
Lines 95832 95832
==========================================
- Hits 70463 70454 -9
- Misses 24052 24061 +9
Partials 1317 1317
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@ahmedabu98 yes but this PR should fix this, right? |
@aromanenko-dev No,it's yet another issue |
@aromanenko-dev I think there are two separate issues blocking the release. This solves one of them, the other is a BQ issue (see comment) that affects both Spark and Flink example test suites |
Ok, so I think we can move forward and merge it |
This slipped in #23751 when migrating to the Spark 3 job-server.
Closes #23935, related to #23907
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.