Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spark 3 job-server jar path for Python test suites #23936

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

mosche
Copy link
Member

@mosche mosche commented Nov 2, 2022

This slipped in #23751 when migrating to the Spark 3 job-server.
Closes #23935, related to #23907


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@mosche
Copy link
Member Author

mosche commented Nov 2, 2022

R: @aromanenko-dev

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@ahmedabu98
Copy link
Contributor

Run Python Examples_Spark

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@aromanenko-dev
Copy link
Contributor

Run Python PreCommit

@aromanenko-dev
Copy link
Contributor

Run Python Examples_Spark

@ahmedabu98
Copy link
Contributor

The failing Spark example tests are due to another issue #23907

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #23936 (3b5aac5) into master (2bf0795) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23936      +/-   ##
==========================================
- Coverage   73.52%   73.51%   -0.01%     
==========================================
  Files         707      707              
  Lines       95832    95832              
==========================================
- Hits        70463    70454       -9     
- Misses      24052    24061       +9     
  Partials     1317     1317              
Flag Coverage Δ
python 83.31% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.47% <0.00%> (-1.39%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 100.00% <0.00%> (+1.61%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aromanenko-dev
Copy link
Contributor

aromanenko-dev commented Nov 2, 2022

@ahmedabu98 yes but this PR should fix this, right?
#23907 (comment)
cc: @mosche

@mosche
Copy link
Member Author

mosche commented Nov 2, 2022

@aromanenko-dev No,it's yet another issue

@ahmedabu98
Copy link
Contributor

@aromanenko-dev I think there are two separate issues blocking the release. This solves one of them, the other is a BQ issue (see comment) that affects both Spark and Flink example test suites

@aromanenko-dev
Copy link
Contributor

Ok, so I think we can move forward and merge it

@aromanenko-dev aromanenko-dev merged commit 153f8e4 into apache:master Nov 2, 2022
@mosche mosche deleted the 23935_fix_jar_path branch November 9, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Portable runner tests use invalid path to Spark 3 job-server jar
3 participants