[ToB] [Frontend] Authentication, unit progress, complete unit, SDK selection

[nausharipov]

Resolves #23692

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[damondouglas]

When I ran flutter test, I saw the following errors. To prepare, I followed the Getting Started directions in learning/tour-of-beam/frontend/README.md.

cd ../../../playground/frontend/playground_components
flutter pub get
cd ../../../learning/tour-of-beam/frontend
flutter pub get

My flutter version is:

Flutter 3.3.9 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b8f7f1f986 (6 weeks ago) • 2022-11-23 06:43:51 +0900
Engine • revision 8f2221fbef
Tools • Dart 2.18.5 • DevTools 2.15.0

Here are the errors:

00:07 +0: ...2_auth/learning/tour-of-beam/frontend/test/overflow_test.dart     lib/pages/tour/state.dart:130:18: Error: The getter 'sdk' isn't defined for the
class 'TourNotifier'.
 - 'TourNotifier' is from 'package:tour_of_beam/pages/tour/state.dart'
 ('lib/pages/tour/state.dart').
Try correcting the name to the name of an existing getter, or defining a getter
or field named 'sdk'.
            sdk: sdk,
                 ^^^
00:09 +0: ...2_auth/learning/tour-of-beam/frontend/test/overflow_test.dart     lib/pages/tour/widgets/playground_demo.dart:51:13: Error: No named parameter
with the name 'goToContextLine'.
            goToContextLine: false,
            ^^^^^^^^^^^^^^^
../../../playground/frontend/playground_components/lib/src/widgets/snippet_edito
r.dart:32:3: Context: Found this candidate, but the arguments don't match.
  SnippetEditor({

[alexeyinkin]

Will this work instead of these 3 lines?

./gradlew :playground:frontend:generateCode

[alexeyinkin]

Or rather

./gradlew :playground:frontend:playground_components:generateCode

[nausharipov]

@alexeyinkin and I have updated README.

[alexeyinkin]

Revert? Looks like it is needed.

[nausharipov]

@alexeyinkin and I have updated README.

[damondouglas]

Based on the instructions, received the following error:

No .dart_tool/package_config.json file found, please run "flutter pub get".

Starting with Dart 2.7, the package_config.json file configures resolution of package import URIs; run "flutter pub get" to generate it.
pub finished with exit code 65

So ran, flutter pub get . FYI I saw a new file to be staged in git:

git status
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   pubspec.lock

Then followed the original instructions: flutter pub run build_runner build and received the error:

[SEVERE] Conflicting outputs were detected and the build is unable to prompt for permission to remove them. These outputs must be removed manually or the build can be run with `--delete-conflicting-outputs`. The outputs are: lib/models/unit_content.g.dart
lib/models/unit_progress.g.dart
lib/repositories/models/get_sdks_response.g.dart
lib/repositories/models/group.g.dart
lib/repositories/models/get_user_progress_response.g.dart
lib/repositories/models/node.g.dart
lib/repositories/models/module.g.dart
lib/repositories/models/unit.g.dart
lib/repositories/models/get_content_tree_response.g.dart
lib/auth/method.g.dart
pub finished with exit code 78

Steps to reproduce:

1. git clone -b issue23692_auth https://github.com/akvelon/beam.git issue23692_auth
2. Follow https://github.com/akvelon/beam/blob/dc4e142f25e1c7efa23b26a04158e1f208ea3864/learning/tour-of-beam/frontend/README.md?plain=1#L37-L39

[nausharipov]

I've added flutter pub run build_runner build --delete-conflicting-outputs.

[nausharipov]

I've committed a fresh pubspec.lock file.

[alexeyinkin]

@damondouglas this README is anyway temporary because Gradle tasks are also in the line for the review:

• [ToB][Frontend] Gradle tasks for ToB frontend #24919

[nausharipov]

The previous overflow_test was experimental and non-functioning. We'll add tests to Tour Of Beam frontend after Playground's frontend integration test is approved: #24731

[damondouglas]

Could we add and reference a GitHub Issue in this TODO?

[nausharipov]

I didn't notice the goToContextLine and sdk errors when resolving merge conflicts. I'll be more attentive next time.

[alexeyinkin]

LGTM (internal review).

[damondouglas]

Based on the instructions, received the following error:

No .dart_tool/package_config.json file found, please run "flutter pub get".

Starting with Dart 2.7, the package_config.json file configures resolution of package import URIs; run "flutter pub get" to generate it.
pub finished with exit code 65

So ran, flutter pub get . FYI I saw a new file to be staged in git:

git status
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   pubspec.lock

Then followed the original instructions: flutter pub run build_runner build and received the error:

[SEVERE] Conflicting outputs were detected and the build is unable to prompt for permission to remove them. These outputs must be removed manually or the build can be run with `--delete-conflicting-outputs`. The outputs are: lib/models/unit_content.g.dart
lib/models/unit_progress.g.dart
lib/repositories/models/get_sdks_response.g.dart
lib/repositories/models/group.g.dart
lib/repositories/models/get_user_progress_response.g.dart
lib/repositories/models/node.g.dart
lib/repositories/models/module.g.dart
lib/repositories/models/unit.g.dart
lib/repositories/models/get_content_tree_response.g.dart
lib/auth/method.g.dart
pub finished with exit code 78

Steps to reproduce:

1. git clone -b issue23692_auth https://github.com/akvelon/beam.git issue23692_auth
2. Follow https://github.com/akvelon/beam/blob/dc4e142f25e1c7efa23b26a04158e1f208ea3864/learning/tour-of-beam/frontend/README.md?plain=1#L37-L39

[damondouglas]

Could we add and reference a GitHub Issue in this TODO?

[damondouglas]

Is this class compensating where the get_it package failed? I'm not familiar with the get_it package and normally able to achieve state management via the InheritedNotiferProvider.

[damondouglas]

Additionally, why is there a need for flutter pub run build_runner build when we see files such as learning/tour-of-beam/frontend/lib/auth/method.g.dart?

[alexeyinkin]

Just above it reads

However, after changes you may need to re-run code generation:

[damondouglas]

Could we instead just rely on which https://pub.dev/documentation/firebase_auth_platform_interface/latest/firebase_auth_platform_interface/AuthProvider-class.html is referenced with a particular button action? If someone clicks the Google button, it initializes Auth flow via Google. If someone clicks the Github button, it initializes Auth flow via Github. The code only seems to use the AuthMethod.google.

[nausharipov]

I've added the firebase_auth_platform_interface package and now logIn takes AuthProvider as an argument.

[damondouglas]

What does a ContentTreeCache cache? Would code comments help explain this?

[nausharipov]

I've added a comment to the Cache class.

[damondouglas]

What about containsKey?

[nausharipov]

Done.

[codecov]

Codecov Report

Merging #24457 (e21b5b7) into master (95e5391) will increase coverage by 0.04%.
The diff coverage is 49.09%.

❗ Current head e21b5b7 differs from pull request most recent head f33a4c2. Consider uploading reports for the commit f33a4c2 to get more accurate results

@@            Coverage Diff             @@
##           master   #24457      +/-   ##
==========================================
+ Coverage   73.07%   73.11%   +0.04%     
==========================================
  Files         735      735              
  Lines       98133    98146      +13     
==========================================
+ Hits        71713    71763      +50     
+ Misses      25061    25019      -42     
- Partials     1359     1364       +5     

Flag	Coverage Δ
go	51.82% <49.09%> (+0.20%)	⬆️
python	82.66% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/sdf.go	71.01% <ø> (ø)
sdks/go/pkg/beam/core/runtime/harness/harness.go	11.02% <0.00%> (+0.08%)	⬆️
sdks/go/pkg/beam/core/sdf/lock.go	0.00% <0.00%> (ø)
...o/pkg/beam/io/rtrackers/offsetrange/offsetrange.go	79.62% <0.00%> (-1.00%)	⬇️
sdks/go/pkg/beam/core/runtime/exec/datasource.go	68.93% <60.71%> (+6.84%)	⬆️
sdks/go/pkg/beam/core/runtime/exec/plan.go	70.00% <100.00%> (+20.67%)	⬆️
sdks/go/pkg/beam/runners/direct/impulse.go	100.00% <100.00%> (ø)
sdks/python/apache_beam/utils/interactive_utils.py	92.68% <0.00%> (-4.88%)	⬇️
sdks/go/pkg/beam/core/metrics/dumper.go	49.20% <0.00%> (-4.77%)	⬇️
...python/apache_beam/runners/worker/worker_status.py	74.66% <0.00%> (-2.00%)	⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[alexeyinkin]

LGTM (internal review).

[damondouglas]

@damccorm LGTM