Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#24515] Remove JRH as option for Dataflow python #24513

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

lukecwik
Copy link
Member

@lukecwik lukecwik commented Dec 3, 2022

This cleans-up a lot of logic related to flag setting with respect to streaming and runner v2 experiments. There is also some dead code removed for configurations not possible any more (e.g. side input override, JRH Create, ...)

This is towards #24515


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@lukecwik lukecwik force-pushed the remove_jrh_python branch 2 times, most recently from 064e309 to f6acbea Compare December 3, 2022 07:06
@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run Seed Job

@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run PubsubIO Performance Test Python

@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run Python Dataflow V2 ValidatesRunner

@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run Python Dataflow ValidatesRunner

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #24513 (43ed75a) into master (53bcb39) will decrease coverage by 0.01%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master   #24513      +/-   ##
==========================================
- Coverage   73.36%   73.35%   -0.02%     
==========================================
  Files         719      719              
  Lines       97206    97122      -84     
==========================================
- Hits        71320    71248      -72     
+ Misses      24538    24526      -12     
  Partials     1348     1348              
Flag Coverage Δ
python 82.98% <97.05%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dks/python/apache_beam/options/pipeline_options.py 93.95% <ø> (-0.02%) ⬇️
...s/python/apache_beam/runners/portability/stager.py 87.04% <ø> (-0.18%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 82.00% <96.49%> (-0.56%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 76.72% <100.00%> (-0.63%) ⬇️
...ache_beam/runners/dataflow/ptransform_overrides.py 98.66% <100.00%> (+7.75%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
.../apache_beam/runners/interactive/dataproc/types.py 93.10% <0.00%> (-3.45%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 75.33% <0.00%> (-1.34%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lukecwik lukecwik changed the title [WIP] Remove JRH as option for Dataflow python [#24515] Remove JRH as option for Dataflow python Dec 3, 2022
@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run Seed Job

@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run Python Dataflow ValidatesRunner

@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run Python Dataflow V2 ValidatesRunner

@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run PubsubIO Performance Test Python

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

Run Python PostCommit

@lukecwik
Copy link
Member Author

lukecwik commented Dec 3, 2022

This cleans-up a lot of logic related to flag setting with respect to streaming and runner v2 experiments
There is also some dead code removed for configurations not possible any more (e.g. side input override, JRH Create, ...)
@lukecwik
Copy link
Member Author

lukecwik commented Dec 5, 2022

Run Seed Job

@lukecwik
Copy link
Member Author

lukecwik commented Dec 5, 2022

Run Python Dataflow ValidatesRunner

@lukecwik
Copy link
Member Author

lukecwik commented Dec 5, 2022

Run Python Dataflow V2 ValidatesRunner

@lukecwik
Copy link
Member Author

lukecwik commented Dec 5, 2022

Run PubsubIO Performance Test Python

@lukecwik
Copy link
Member Author

lukecwik commented Dec 5, 2022

Tested within google with cl/492869422, also contains patches for import into Google

@lukecwik lukecwik merged commit 8ec0568 into apache:master Dec 6, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
This cleans-up a lot of logic related to flag setting with respect to streaming and runner v2 experiments
There is also some dead code removed for configurations not possible any more (e.g. side input override, JRH Create, ...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants