-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#24515] Remove JRH as option for Dataflow python #24513
Conversation
064e309
to
f6acbea
Compare
Run Seed Job |
Run PubsubIO Performance Test Python |
Run Python Dataflow V2 ValidatesRunner |
Run Python Dataflow ValidatesRunner |
Codecov Report
@@ Coverage Diff @@
## master #24513 +/- ##
==========================================
- Coverage 73.36% 73.35% -0.02%
==========================================
Files 719 719
Lines 97206 97122 -84
==========================================
- Hits 71320 71248 -72
+ Misses 24538 24526 -12
Partials 1348 1348
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Seed Job |
cc397be
to
413d359
Compare
Run Python Dataflow ValidatesRunner |
Run Python Dataflow V2 ValidatesRunner |
Run PubsubIO Performance Test Python |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Python PostCommit |
This cleans-up a lot of logic related to flag setting with respect to streaming and runner v2 experiments There is also some dead code removed for configurations not possible any more (e.g. side input override, JRH Create, ...)
413d359
to
43ed75a
Compare
Run Seed Job |
Run Python Dataflow ValidatesRunner |
Run Python Dataflow V2 ValidatesRunner |
Run PubsubIO Performance Test Python |
Tested within google with cl/492869422, also contains patches for import into Google |
This cleans-up a lot of logic related to flag setting with respect to streaming and runner v2 experiments There is also some dead code removed for configurations not possible any more (e.g. side input override, JRH Create, ...)
This cleans-up a lot of logic related to flag setting with respect to streaming and runner v2 experiments. There is also some dead code removed for configurations not possible any more (e.g. side input override, JRH Create, ...)
This is towards #24515
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.