-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error message for mismatched pipelines #24834
improve error message for mismatched pipelines #24834
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24834 +/- ##
==========================================
+ Coverage 65.19% 73.01% +7.82%
==========================================
Files 731 734 +3
Lines 97960 98104 +144
==========================================
+ Hits 63861 71635 +7774
+ Misses 32743 25113 -7630
Partials 1356 1356
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @tvalentyn could I ask a question that why there are two checks were failed? |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Apologies for the long response, I was OOO for a bit. Thanks for the fix! Precommit errors are most likely a flake, we can re-run the suite. Lint errors is visible if you follow the "Details" -> Console Output link. The error is:
|
see also: https://s.apache.org/beam-python-dev-wiki which talks about how to run linter locally during development. |
Linter errors should be fixed, we can merge once tests run. |
improve error message for mismatched pipelines
fix issue: #18040
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.