-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#24515] Delete the JRH #24967
[#24515] Delete the JRH #24967
Conversation
Move :runners:google-cloud-dataflow-java:worker:legacy-worker to :runners:google-cloud-dataflow-java:worker deleting the FnApi runner harness (aka JRH) and the code that was powering it. Fixes apache#24515
Codecov Report
@@ Coverage Diff @@
## master #24967 +/- ##
=======================================
Coverage 73.12% 73.13%
=======================================
Files 735 735
Lines 98146 98148 +2
=======================================
+ Hits 71773 71783 +10
+ Misses 25010 25002 -8
Partials 1363 1363
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run GoPortable PreCommit |
Run PythonDocs PreCommit |
Run SQL_Java17 PreCommit |
Run Python PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
whitespace check broken by #24951 |
Run Whitespace PreCommit |
Run Java_Kafka_IO_Direct PreCommit |
Run PostCommit_Java_Dataflow |
Run Java PostCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! this LGTM to the best of my knowledge
Besides Java PostCommit (which also runs zetasketch) there are also load tests, nexmark, tpcds build affected. Will follow up on cron jobs once this is merged.
...w-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relevant postcommit tests passed.
Thanks!
Move :runners:google-cloud-dataflow-java:worker:legacy-worker to :runners:google-cloud-dataflow-java:worker deleting the FnApi runner harness (aka JRH) and the code that was powering it.
Towards #25103
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.