Tour of beam learning materials CI/CD refactoring and templating #25080
Conversation
…' into tour-of-beam-learning-materials-refactoring
|
R: @TSultanov |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
| sdk: | ||
| - Java | ||
| - Python | ||
| - Go | ||
| id: from-memory | ||
| name: Creating in-memory PCollections | ||
| taskName: ParDo |
There was a problem hiding this comment.
Please add newline to the end
| sdk: | ||
| - Java | ||
| - Python | ||
| - Go | ||
| id: from-csv | ||
| name: Creating PCollections from csv files | ||
| taskName: CSV |
There was a problem hiding this comment.
Please add newline to the end
| @@ -46,6 +46,7 @@ func getExampleNode(id string, sdk tob.Sdk) tob.Node { | |||
| } | |||
|
|
|||
| func TestSample(t *testing.T) { | |||
| //trees, err := CollectLearningTree(filepath.Join("..", "..", "samples", "learning-content")) | |||
There was a problem hiding this comment.
Remove commented out code
|
R: @damccorm |
| } | ||
| node := &tob.Node{} | ||
| for _, f := range files { |
There was a problem hiding this comment.
This isn't technically a problem with this code change, but I think this loop has a potential problem. If the first file has an associated error, but the second does not it will reset err to nil
Probably we should be early returning if err != nil after the switch
There was a problem hiding this comment.
Thank you! Nice catch!
| @@ -25,6 +25,19 @@ The Direct Runner executes pipelines on your machine and is designed to validate | |||
|
|
|||
| Using the Direct Runner for testing and development helps ensure that pipelines are robust across different Beam runners. In addition, debugging failed runs can be a non-trivial task when a pipeline executes on a remote cluster. Instead, it is often faster and simpler to perform local unit testing on your pipeline code. Unit testing your pipeline locally also allows you to use your preferred local debugging tools. | |||
|
|
|||
| {{if (eq .Sdk "go")}} | |||
| In the SDK Go, the default is runner **DirectRunner**. | |||
There was a problem hiding this comment.
| In the SDK Go, the default is runner **DirectRunner**. | |
| In the Go SDK, the default is runner **DirectRunner**. |
| {{if (eq .Sdk "go")}} | ||
| In the SDK Go, the default is runner **DirectRunner**. | ||
|
|
||
| Additionally, you can read [here](https://beam.apache.org/documentation/runners/direct/) |
There was a problem hiding this comment.
| Additionally, you can read [here](https://beam.apache.org/documentation/runners/direct/) | |
| Additionally, you can read more about the Direct Runner [here](https://beam.apache.org/documentation/runners/direct/) |
| {{end}} | ||
|
|
||
| {{if (eq .Sdk "python")}} | ||
| In the SDK Python, the default is runner **DirectRunner**. |
There was a problem hiding this comment.
| In the SDK Python, the default is runner **DirectRunner**. | |
| In the Python SDK, the default is runner **DirectRunner**. |
...r-of-beam/learning-content/introduction/introduction-concepts/runner-concepts/description.md
Show resolved
Hide resolved
| id: guide | ||
| name: Tour of Beam Guide | ||
| complexity: BASIC |
There was a problem hiding this comment.
Was removing this line intentional?
|
I'll merge once CI completes |
Tour of Beam learning materials refactored to support template learning materials
Introduction module learning materials updated to match new LM structure
resolves #25079
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.