Schema convenience functions #25196
Merged
Schema convenience functions #25196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds to make schemas a bit easier to read in Java
chamikaramj
reviewed
Jan 27, 2023
| @@ -142,82 +142,163 @@ public Builder addByteField(String name) { | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder addNullableByteField(String name) { | |||
| fields.add(Field.nullable(name, FieldType.BYTE)); | |||
There was a problem hiding this comment.
Probably we should use the existing "addNullableField" function when implementing these.
There was a problem hiding this comment.
sure, no problem
added 2 commits
January 26, 2023 16:28
|
Updated to use addNullableField |
|
Run Java_GCP_IO_Direct PreCommit |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @apilloud for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Java PreCommit |
|
Yay, everything passed finally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While spending a bunch of times working with writing down schemas in Java recently one of the things that kept coming up was the need to make fields nullable more often than not. While there are convenience functions for NOT NULL fields there aren't equivalent nullable versions. This is just a small PR that adds equivalent convenience methods to the schema builder for nullable fields.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.