-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WatchFilePattern #25393
Add WatchFilePattern #25393
Conversation
dc10c8d
to
9394f03
Compare
Codecov Report
@@ Coverage Diff @@
## master #25393 +/- ##
==========================================
- Coverage 72.87% 72.81% -0.07%
==========================================
Files 750 751 +1
Lines 99471 99611 +140
==========================================
+ Hits 72494 72534 +40
- Misses 25608 25708 +100
Partials 1369 1369
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run PythonLint PreCommit |
R : @damccorm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - had some comments, but they're all minor or total nits. Thanks!
sdks/python/apache_beam/examples/inference/pytorch_image_classification_with_side_inputs.py
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/pytorch_image_classification_with_side_inputs.py
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/pytorch_image_classification_with_side_inputs.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/pytorch_image_classification_with_side_inputs.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/pytorch_image_classification_with_side_inputs.py
Outdated
Show resolved
Hide resolved
side_input = pipeline | WatchFilePattern( | ||
interval=known_args.interval, file_pattern=known_args.file_pattern) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, just 2 lines and an additional arg to RunInference to do this!
TODO to myself: Change the typo after #25399 is merged |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
sdks/python/apache_beam/examples/inference/pytorch_image_classification_with_side_inputs.py
Show resolved
Hide resolved
Merged - sorry for the delay, had to retry some precommit checks |
Run PythonDocs PreCommit |
Run Whitespace PreCommit |
I addressed almost all comments. PTAL @damccorm . Thanks for the suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last small typo
sdks/python/apache_beam/examples/inference/pytorch_image_classification_with_side_inputs.py
Outdated
Show resolved
Hide resolved
…ification_with_side_inputs.py Co-authored-by: Danny McCormick <dannymccormick@google.com>
WatchFilePattern Ptransform.
Completes Part 2 of #24042
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.