Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#24789][prism] Add testdofns for later #25557

Merged
merged 2 commits into from
Feb 20, 2023
Merged

[#24789][prism] Add testdofns for later #25557

merged 2 commits into from
Feb 20, 2023

Conversation

lostluck
Copy link
Contributor

Add the test DoFns used for bootstrap testing of prism. Unused in this PR.

These are used in the main pipeline tests for the runner, but aren't very interesting themselves.

A separate suit covers complex DoFns WRT "separation", like SDFs, process continuation and watermark estimating.

See #24789 for more information.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #25557 (ee80586) into master (6667eb4) will decrease coverage by 0.13%.
The diff coverage is 1.70%.

❗ Current head ee80586 differs from pull request most recent head d37074b. Consider uploading reports for the commit d37074b to get more accurate results

@@            Coverage Diff             @@
##           master   #25557      +/-   ##
==========================================
- Coverage   72.64%   72.51%   -0.13%     
==========================================
  Files         763      764       +1     
  Lines      101060   101236     +176     
==========================================
  Hits        73413    73413              
- Misses      26226    26401     +175     
- Partials     1421     1422       +1     
Flag Coverage Δ
go 52.03% <1.70%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/go/pkg/beam/runners/prism/internal/testdofns.go 1.70% <1.70%> (ø)
...o/pkg/beam/runners/prism/internal/worker/worker.go 63.42% <0.00%> (-1.17%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 74.66% <0.00%> (-0.67%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.46% <0.00%> (+0.15%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 94.33% <0.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lostluck
Copy link
Contributor Author

R: @johannaojeling

This one is what it says on the tin. A bunch of Test DoFns that will eventually migrate into just the test file itself, instead of living in the package.

Having them in the "production" part of the package simplifies getting coverage numbers while iterating, and ensuring the different methods on the DoFns are activated as expected. Once metrics support in the runner is sufficiently robust, that can be changed to using counters and similar.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@lostluck lostluck changed the title [prism] Add testdofns for later [#24789][prism] Add testdofns for later Feb 20, 2023
Copy link
Contributor

@johannaojeling johannaojeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sdks/go/pkg/beam/runners/prism/internal/testdofns.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/runners/prism/internal/testdofns.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/runners/prism/internal/testdofns.go Outdated Show resolved Hide resolved
@lostluck lostluck merged commit bc0284b into master Feb 20, 2023
@lostluck lostluck deleted the prism-testdofns branch February 20, 2023 16:56
lostluck added a commit to lostluck/beam that referenced this pull request Feb 20, 2023
* [prism] Add testdofns for later

* [prism] typo comments
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
* [prism] Add testdofns for later

* [prism] typo comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants