-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#24789][prism] Add testdofns for later #25557
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25557 +/- ##
==========================================
- Coverage 72.64% 72.51% -0.13%
==========================================
Files 763 764 +1
Lines 101060 101236 +176
==========================================
Hits 73413 73413
- Misses 26226 26401 +175
- Partials 1421 1422 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This one is what it says on the tin. A bunch of Test DoFns that will eventually migrate into just the test file itself, instead of living in the package. Having them in the "production" part of the package simplifies getting coverage numbers while iterating, and ensuring the different methods on the DoFns are activated as expected. Once metrics support in the runner is sufficiently robust, that can be changed to using counters and similar. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* [prism] Add testdofns for later * [prism] typo comments
* [prism] Add testdofns for later * [prism] typo comments
Add the test DoFns used for bootstrap testing of prism. Unused in this PR.
These are used in the main pipeline tests for the runner, but aren't very interesting themselves.
A separate suit covers complex DoFns WRT "separation", like SDFs, process continuation and watermark estimating.
See #24789 for more information.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.