Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload HbaseIO with KV<RowKey, RowMutations> #25831

Closed
wants to merge 9 commits into from

Conversation

georgecma
Copy link
Contributor

@georgecma georgecma commented Mar 13, 2023

Add HbaseIO support for writing RowMutations (ordered by rowkey) to Hbase.
Fixes #25830

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@georgecma georgecma marked this pull request as ready for review March 14, 2023 21:33
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Mar 15, 2023

test not run due to spotbug: HbaseRowMutationIOTest.java:56 "You should name sfl4j Loggers as LOG."

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looked at HBaseIO but not yet tests and utility classes.

By saying "in-order write", what is the requirement? Is that something like <Key=1, RowMutations1> will be written prior to <Key=2, RowMutations1> ? Or just Mutations in a RowMutations ("Performs multiple mutations atomically on a single row.") should be executed in order?

@aromanenko-dev
Copy link
Contributor

aromanenko-dev commented Mar 16, 2023

@georgecma Thanks for contribution! I see that this PR is created from your local master branch. Please, create and use a dedicated feature branch for this.

georgecma and others added 4 commits March 16, 2023 12:59
@georgecma
Copy link
Contributor Author

Add HbaseIO support for writing RowMutations (ordered by rowkey) to Hbase.
Fixes #25830

Thanks, created new branch after responding to @Abacn's comments. New PR is #25864
Closing this PR

@georgecma georgecma closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Overload HbaseIO with KV<RowKey, RowMutations>
3 participants