Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key param support for helper Combiners #25895

Merged
merged 7 commits into from
Mar 29, 2023

Conversation

harrisonlimh
Copy link
Contributor

addresses #25888

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #25895 (d2254a1) into master (ddae966) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d2254a1 differs from pull request most recent head 643ea83. Consider uploading reports for the commit 643ea83 to get more accurate results

@@            Coverage Diff             @@
##           master   #25895      +/-   ##
==========================================
- Coverage   71.42%   71.41%   -0.01%     
==========================================
  Files         779      779              
  Lines      102534   102534              
==========================================
- Hits        73237    73227      -10     
- Misses      27837    27847      +10     
  Partials     1460     1460              
Flag Coverage Δ
python 79.96% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/combiners.py 93.43% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@@ -317,7 +317,7 @@ def LargestPerKey(pcoll, n, key=None):

@staticmethod
@ptransform.ptransform_fn
def SmallestPerKey(pcoll, n, key=None, reverse=True):
def SmallestPerKey(pcoll, n, *, reverse=True, key=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given we force KW-only arguments, we can move key before reverse, same as we do in other combiners.

@tvalentyn
Copy link
Contributor

please fix lint, formatter and add a note to CHANGES.md

CHANGES.md Outdated Show resolved Hide resolved
@tvalentyn
Copy link
Contributor

noting that tests passed.

@tvalentyn tvalentyn merged commit 9f582e5 into apache:master Mar 29, 2023
@tvalentyn
Copy link
Contributor

Thanks, @harrisonlimh !

jakubrauch pushed a commit to jakubrauch/beam that referenced this pull request Apr 27, 2023
Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>
rezarokni pushed a commit to rezarokni/beam that referenced this pull request May 22, 2023
Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants