-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set an auth key in multi_process_shared.py #26172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26172 +/- ##
==========================================
- Coverage 71.17% 71.16% -0.01%
==========================================
Files 787 787
Lines 103294 103319 +25
==========================================
+ Hits 73523 73532 +9
- Misses 28283 28299 +16
Partials 1488 1488
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @robertwb |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
retest this please |
1 similar comment
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
Right now, multi_process_shared doesn't set an auth key. When that happens, the manager still creates an auth key for that process based on the current process's authKey - https://github.com/python/cpython/blob/4dc339b4d69195448207e1faecc3e258700daf33/Lib/multiprocessing/managers.py#L503
This causes cross-process authentication to fail and means that multi_process_shared.py doesn't correctly work.
This PR fixes this by using a constant auth key for all managers/requesters/processes.
I was able to get an example running on Dataflow using this approach. #26178 also causes unit tests to fail which will be fixed by this change, so I'm deferring tests to that PR
Fixes #26167
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.