Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set an auth key in multi_process_shared.py #26172

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Apr 7, 2023

Right now, multi_process_shared doesn't set an auth key. When that happens, the manager still creates an auth key for that process based on the current process's authKey - https://github.com/python/cpython/blob/4dc339b4d69195448207e1faecc3e258700daf33/Lib/multiprocessing/managers.py#L503

This causes cross-process authentication to fail and means that multi_process_shared.py doesn't correctly work.

This PR fixes this by using a constant auth key for all managers/requesters/processes.

I was able to get an example running on Dataflow using this approach. #26178 also causes unit tests to fail which will be fixed by this change, so I'm deferring tests to that PR

Fixes #26167


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #26172 (1a6fc7c) into master (87db1ae) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #26172      +/-   ##
==========================================
- Coverage   71.17%   71.16%   -0.01%     
==========================================
  Files         787      787              
  Lines      103294   103319      +25     
==========================================
+ Hits        73523    73532       +9     
- Misses      28283    28299      +16     
  Partials     1488     1488              
Flag Coverage Δ
python 79.85% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/python/apache_beam/utils/multi_process_shared.py 97.43% <100.00%> (+0.06%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor Author

damccorm commented Apr 7, 2023

R: @robertwb

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm
Copy link
Contributor Author

retest this please

1 similar comment
@damccorm
Copy link
Contributor Author

retest this please

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@damccorm damccorm merged commit 3424320 into apache:master Apr 17, 2023
@damccorm damccorm deleted the users/damccorm/mps-auth branch April 17, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: multi_process_shared.py doesn't correctly handle cross process authentication
2 participants