Add docs on pre/post processing operations and dlq support #26772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @rszper |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
rszper
reviewed
May 18, 2023
| @@ -192,7 +192,9 @@ with pipeline as p: | |||
|
|
|||
| For more information on resource hints, see [Resource hints](/documentation/runtime/resource-hints/). | |||
|
|
|||
| ## Use a keyed ModelHandler | |||
| ## RunInference Patterns | |||
There was a problem hiding this comment.
We should include text after this header describing the section. Something along the lines of:
This section provides examples of RunInference patterns.
(But hopefully more informative than that.)
There was a problem hiding this comment.
Done - let me know if you think it sounds ok: "This section suggests patterns and best practices that can be used to make your inference pipelines simpler, more robust, and more efficient."
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
damccorm
commented
May 19, 2023
| @@ -192,7 +192,9 @@ with pipeline as p: | |||
|
|
|||
| For more information on resource hints, see [Resource hints](/documentation/runtime/resource-hints/). | |||
|
|
|||
| ## Use a keyed ModelHandler | |||
| ## RunInference Patterns | |||
There was a problem hiding this comment.
Done - let me know if you think it sounds ok: "This section suggests patterns and best practices that can be used to make your inference pipelines simpler, more robust, and more efficient."
rszper
reviewed
May 19, 2023
website/www/site/content/en/documentation/sdks/python-machine-learning.md
Outdated
Show resolved
Hide resolved
|
I'll merge this once 2.48 is released |
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
) * Add docs on pre/post processing operations and dlq support * Apply suggestions from code review Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com> * Add description to RunInference Patterns * Wording Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com> --------- Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds docs for the DLQ and pre/postprocess features added in #26309 and #26261
This shouldn't be merged until 2.48 is released
✨ RENDERED ✨
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.