Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Python] use get_buffer to fetch buffer when the buffer is None" #27491

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

AnandInguva
Copy link
Contributor

Reverts #27373

Internal beam tests are failing. Investigate them and raise a PR if they pass

@AnandInguva
Copy link
Contributor Author

R: @tvalentyn cc: @pabloem

sample test

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #27491 (6bfc208) into master (85a78c6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #27491   +/-   ##
=======================================
  Coverage   71.16%   71.17%           
=======================================
  Files         861      861           
  Lines      104519   104517    -2     
=======================================
+ Hits        74386    74388    +2     
+ Misses      28584    28580    -4     
  Partials     1549     1549           
Flag Coverage Δ
python 80.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eam/runners/portability/fn_api_runner/fn_runner.py 87.85% <100.00%> (-0.04%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva AnandInguva merged commit ef8fd43 into master Jul 13, 2023
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 17, 2023
AnandInguva referenced this pull request Jul 26, 2023
* [GCP] [BigQuery] Handle totalBytesProcessed NoneType

* Update CHANGES.md

* lint / whitespace

---------

Co-authored-by: Yi Hu <yathu@google.com>
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
@Abacn Abacn deleted the revert-27373-direct_runner_bug branch August 22, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants