Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#27558] Update required Go version to 1.20. #27559

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Jul 19, 2023

Also pulls the builds to the latest patch release for Go 1.20.6 (released on July 11th).

Fixes #27558.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #27559 (6f89d39) into master (b2e00ef) will decrease coverage by 0.02%.
Report is 92 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27559      +/-   ##
==========================================
- Coverage   71.14%   71.13%   -0.02%     
==========================================
  Files         861      859       -2     
  Lines      104560   104506      -54     
==========================================
- Hits        74389    74338      -51     
+ Misses      28621    28610      -11     
- Partials     1550     1558       +8     
Flag Coverage Δ
go 53.55% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lostluck
Copy link
Contributor Author

Run Go PreCommit

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@lostluck
Copy link
Contributor Author

There's an issue with Go 1.20.6 and test containers (among other socket users):

testcontainers/testcontainers-go#1359 with the go bug tracked at
golang/go#61431 . Basically, fixing a CVE issue broke this, and though technically the behavior being used was disallowed by the relevant RFC spec.

@lostluck
Copy link
Contributor Author

lostluck commented Jul 19, 2023

The github actions will start failing on this, and due to this being a breaking behavioral change that also affects Kubernetes, I expect we'll see a 1.20.7 sometime this week.

This doesn't block other work related to setting prism as default, so I'll be getting other PRs out shortly.

@lostluck
Copy link
Contributor Author

Docker v24.0.5 release https://github.com/moby/moby/releases/tag/v24.0.5 fixes it's issue with go1.20.6, which should unblock this PR.

@lostluck
Copy link
Contributor Author

Run Java PreCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey jrmccluskey merged commit 5a54ee6 into apache:master Jul 27, 2023
20 checks passed
bullet03 pushed a commit to akvelon/beam that referenced this pull request Aug 11, 2023
* Update required Go version to 1.20.

* Use correct issue number for Changes.md

* Require newer docker dep to resolve issue there.

---------

Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task][GoSDK]: Update Min Go version to 1.20
2 participants