Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#26902] Add switch for supporting cross compile arm64 for dataflow #27649

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Jul 25, 2023

Adds a switch to prepare for Arm64 support against Google Cloud Dataflow, via machine type specification.

This change adds an additional option for supporting arbitrary architectures for the automatic cross compile which is necessary for adding testing against the service. See #26902 and 27311.

Fixes debug message parameter ordering on the cross compile.

A subsequent change should have a more general flag for users who want to automatically cross compile to target other machines. This should be added to JobOpts. End users can continue to work around this by building their own worker binary and setting the --worker_binary flag when submitting a job, per https://beam.apache.org/documentation/sdks/go-cross-compilation/.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@lostluck
Copy link
Contributor Author

cc: @celeste-zeng

@github-actions github-actions bot removed the docker label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #27649 (f6a960e) into master (1526263) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #27649      +/-   ##
==========================================
- Coverage   71.09%   71.08%   -0.02%     
==========================================
  Files         859      859              
  Lines      104555   104566      +11     
==========================================
- Hits        74338    74331       -7     
- Misses      28660    28676      +16     
- Partials     1557     1559       +2     
Flag Coverage Δ
go 53.54% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...o/pkg/beam/runners/dataflow/dataflowlib/execute.go 0.00% <0.00%> (ø)
...go/pkg/beam/runners/universal/runnerlib/compile.go 0.00% <0.00%> (ø)
...go/pkg/beam/runners/universal/runnerlib/execute.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lostluck
Copy link
Contributor Author

Thanks for the review!
Sorry, I didn't see the bot messages until I sent a tag to Jack :O. Serves me right for not refreshing my tab first.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants