-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#26902] Add switch for supporting cross compile arm64 for dataflow #27649
Conversation
cc: @celeste-zeng |
Codecov Report
@@ Coverage Diff @@
## master #27649 +/- ##
==========================================
- Coverage 71.09% 71.08% -0.02%
==========================================
Files 859 859
Lines 104555 104566 +11
==========================================
- Hits 74338 74331 -7
- Misses 28660 28676 +16
- Partials 1557 1559 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for the review! |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Adds a switch to prepare for Arm64 support against Google Cloud Dataflow, via machine type specification.
This change adds an additional option for supporting arbitrary architectures for the automatic cross compile which is necessary for adding testing against the service. See #26902 and 27311.
Fixes debug message parameter ordering on the cross compile.
A subsequent change should have a more general flag for users who want to automatically cross compile to target other machines. This should be added to JobOpts. End users can continue to work around this by building their own worker binary and setting the --worker_binary flag when submitting a job, per https://beam.apache.org/documentation/sdks/go-cross-compilation/.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.