Add back docker prune step between python container pushes #28033
Conversation
|
R: @lostluck |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28033 +/- ##
==========================================
- Coverage 72.32% 72.31% -0.01%
==========================================
Files 678 678
Lines 99744 99744
==========================================
- Hits 72135 72133 -2
- Misses 26045 26047 +2
Partials 1564 1564
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
https://github.com/apache/beam/actions/runs/5882454184 Running to validate. |
|
FYI: @celeste-zeng as the original author and @tvalentyn as the reviewr of the PR. Apparently the python container ordering there was load bearing. |
sdks/python/container/build.gradle
Outdated
| String cur = "3" + i | ||
| String prev = "3" + (i-1) | ||
| tasks.register("push" + cur) { | ||
| if (cur != "38") { |
There was a problem hiding this comment.
what is special about 38 ?
There was a problem hiding this comment.
ok, it's the first one in the chain
There was a problem hiding this comment.
we should try to hardcode python versions in as few pieces as possible. Ideally, we should have lowest supported and highest supported constant, similar to
. Maybe in top level settings.gradle. Other place that would benefit from this: https://github.com/apache/beam/blob/master/sdks/python/test-suites/gradle.properties . If that's too much hassle right now, consider at least not adding lowest/highest constant in this file, so that we programmatically evaluate line 49.There was a problem hiding this comment.
I extracted to variable constants here to keep the change small since there's a good chance we're cherry picking this
* Add back docker prune step between python container pushes * Extract to variables * Define var inside loop to avoid async race condition
This ordering/intermediate prune on releases got removed in https://github.com/apache/beam/pull/27836/files but the intermediate prune is still needed
Fixes #28030
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.